Update dependency tornado to v6.5.8 [SECURITY] - #1004
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
6.5.7→6.5.8Tornado: Incomplete fix for CVE-2026-35536: cookie attribute injection re-opened via the legacy case-insensitive
**kwargspath inset_cookieGHSA-wwv5-g3v4-889x
More information
Details
Summary
The CVE-2026-35536 fix added a validation loop that rejects
[\x00-\x20\x3b\x7f], but only for thehardcoded lowercase keys
name/domain/path/samesite. The still-live deprecated**kwargspathwrites attacker-supplied attribute values straight into the
Morselwith no validation, and becauseMorsel.__setitem__is case-insensitive, a capitalized kwarg (Domain=,Path=,SameSite=,Max-Age=)routes to the same reserved attribute while bypassing the loop — re-opening
;-delimited attribute injection.The patch's regression test (
SetCookieForbiddenCharHandler) only exercises the four named params, never the**kwargspath, so the gap is not regression-covered.Affected code
tornado/web.py→RequestHandler.set_cookie: the validation loop covers only the lowercase named args;the trailing
if kwargs:loop doesmorsel[k] = vwith no character validation.Steps to reproduce
GET /upper(usesDomain=kwarg) emitsSet-Cookie: c_upper=v; Domain=evil.com; Secure; SameSite=None; Path=/;GET /lower(uses lowercasedomain=) returns aCookieError.Impact
Injection of independent cookie attributes (force/drop
Secure/HttpOnly/SameSite, rebindDomain/Path)— the same impact CVE-2026-35536 closed, via the sibling path the patch missed. Conditional on the app using
a capitalized/legacy keyword.
Suggested remediation
Apply the same
[\x00-\x20\x3b\x7f]validation to every entry in the**kwargsloop (after normalizing thekey case), or remove the deprecated kwargs path; add a regression test for capitalized kwargs.
Credit
Reported as part of an incomplete-patch measurement study (responsible disclosure).
Severity
CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:P/VC:L/VI:L/VA:N/SC:N/SI:N/SA:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
tornado: multipart split() creates huge temp list before max_parts check -> memory amplification DoS (httputil.py:34)
GHSA-8423-8fgw-73vq
More information
Details
Description
Summary
parse_multipart_form_data(httputil.py:34) callsdata.split(b"--"+boundary+b"\r\n")before themax_partscheck (:35).A 600KB body with 100k parts creates a 100k-element transient list first,
then rejects transient memory amplification (each split element is a copy).
Pre-auth HTTP DoS.
Root cause
PoC
gist: https://gist.github.com/afldl/649861f25d39b53b7edbe0298e171617
poc.py+output.txt(100k parts from 600KB transient list).Fix
Count separators without materializing the list (e.g.
data.count(b"--"+boundary)first).Credit
Reported by afldl, 2026-07.
Severity
CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:L/SC:N/SI:N/SA:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
tornadoweb/tornado (tornado)
v6.5.8Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.