tools: fix positional input file handling in scmp_bpf_disasm - #494
Open
1234binpig wants to merge 1 commit into
Open
tools: fix positional input file handling in scmp_bpf_disasm#4941234binpig wants to merge 1 commit into
1234binpig wants to merge 1 commit into
Conversation
After getopt() processing, optind points to the first positional argument. The disassembler instead opened argv[optind - 1], which can cause an option argument to be treated as the input file. Use argv[optind] and document the optional BPF input file in the usage message. Signed-off-by: huangwenbin <huangwenbin@kylinos.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scmp_bpf_disasmusesargv[optind - 1]for the positional input file after option parsing.Since
optindalready points to the first remaining positional argument, commands such as:can attempt to open the option argument instead of
filter.bpf.Fix
Use
argv[optind]for the positional input file and document the optional[bpf_file]argument in the usage message.Testing
Verified manually with a generated seccomp-BPF file:
-a x86 <file>works correctly;-d -a x86 <file>works correctly.The full
make checksuite has an existing regression failure on this environment; the same failure is reproduced on unmodifiedmaster.