pfc: propagate buffered output errors - #495
Open
1234binpig wants to merge 1 commit into
Open
Conversation
gen_pfc_generate() ignored errors reported by fflush() and fclose(), causing seccomp_export_pfc() to report success even when buffered output could not be written. Preserve the first output error while still closing the stream, and add a regression test using /dev/full. Signed-off-by: huangwenbin <huangwenbin@kylinos.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gen_pfc_generate()ignored errors reported byfflush()andfclose().Because stdio output is buffered, write failures can first be reported while flushing or closing the stream. In that case,
seccomp_export_pfc()could report success even though the generated output was not fully written.Fix
Propagate buffered output errors while still closing the stream exactly once. If both operations fail, preserve the first reported output error.
Testing
Added a regression test using
/dev/full.Verified that: