Skip to content

Generic codec class#5006

Open
polybassa wants to merge 6 commits into
secdev:masterfrom
polybassa:generic_codec
Open

Generic codec class#5006
polybassa wants to merge 6 commits into
secdev:masterfrom
polybassa:generic_codec

Conversation

@polybassa

Copy link
Copy Markdown
Contributor

This introduces common classes for shared code between codecs like CBOR and ASN.1

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.87342% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.30%. Comparing base (fda6032) to head (7875b2f).

Files with missing lines Patch % Lines
scapy/libs/codec.py 88.79% 13 Missing ⚠️
scapy/asn1/ber.py 88.88% 1 Missing ⚠️
scapy/asn1fields.py 93.33% 1 Missing ⚠️
scapy/cbor/cborcodec.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5006   +/-   ##
=======================================
  Coverage   80.30%   80.30%           
=======================================
  Files         386      387    +1     
  Lines       96127    96163   +36     
=======================================
+ Hits        77191    77220   +29     
- Misses      18936    18943    +7     
Files with missing lines Coverage Δ
scapy/asn1packet.py 90.00% <100.00%> (ø)
scapy/cbor/cborfields.py 77.90% <100.00%> (+0.05%) ⬆️
scapy/asn1/ber.py 82.93% <88.88%> (+0.21%) ⬆️
scapy/asn1fields.py 81.94% <93.33%> (-1.70%) ⬇️
scapy/cbor/cborcodec.py 88.31% <88.88%> (+0.54%) ⬆️
scapy/libs/codec.py 88.79% <88.79%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2

Copy link
Copy Markdown
Member

I think there are too much comments in this PR

@polybassa

Copy link
Copy Markdown
Contributor Author

Removed comments

@polybassa polybassa requested a review from gpotter2 July 1, 2026 12:37
Nils Weiss added 6 commits July 1, 2026 20:55
…lementations

AI-Assisted: yes (GitHub CoPilot Auto)
…lementations

AI-Assisted: yes (GitHub CoPilot Auto)
AI-Assisted: no
AI-Assisted: no
AI-Assisted: no
AI-Assisted: yes (Cursor AI)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants