Ticketer: improve consistency when editing#5027
Merged
Merged
Conversation
gpotter2
commented
Jun 28, 2026
Member
- some timezones are dropped when editing a ticket, fix that
- padding was not like on Windows when building the UPN PAC structure
- CLIENT_INFO should be the same timestamp as the outer kerberos authtime. Make sure of that when resigning, else there might be an error related to "message integrity"
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5027 +/- ##
==========================================
- Coverage 80.34% 80.33% -0.01%
==========================================
Files 386 386
Lines 96034 96037 +3
==========================================
+ Hits 77154 77156 +2
- Misses 18880 18881 +1
🚀 New features to boost your workflow:
|
6738423 to
6853c50
Compare
- Ticketer: bad timezone conversions, improve handling of PAC_CLIENT_INFO when editing a ticket - kerberos: support new error type when a password change is necessary - DNS: handle case where a weird payload is returned AI-Assisted: no
AI-Assisted: no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.