Skip to content

Ticketer: improve consistency when editing#5027

Merged
gpotter2 merged 2 commits into
secdev:masterfrom
gpotter2:other-fixes
Jun 29, 2026
Merged

Ticketer: improve consistency when editing#5027
gpotter2 merged 2 commits into
secdev:masterfrom
gpotter2:other-fixes

Conversation

@gpotter2

Copy link
Copy Markdown
Member
  • some timezones are dropped when editing a ticket, fix that
  • padding was not like on Windows when building the UPN PAC structure
  • CLIENT_INFO should be the same timestamp as the outer kerberos authtime. Make sure of that when resigning, else there might be an error related to "message integrity"

@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.33%. Comparing base (fbd0956) to head (563dcb4).

Files with missing lines Patch % Lines
scapy/modules/ticketer.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5027      +/-   ##
==========================================
- Coverage   80.34%   80.33%   -0.01%     
==========================================
  Files         386      386              
  Lines       96034    96037       +3     
==========================================
+ Hits        77154    77156       +2     
- Misses      18880    18881       +1     
Files with missing lines Coverage Δ
scapy/layers/dns.py 83.85% <ø> (ø)
scapy/layers/kerberos.py 57.56% <100.00%> (ø)
scapy/layers/ldap.py 66.66% <ø> (-0.13%) ⬇️
scapy/layers/msrpce/mspac.py 91.38% <100.00%> (+0.60%) ⬆️
scapy/layers/ntlm.py 81.57% <100.00%> (+0.19%) ⬆️
scapy/layers/smbclient.py 69.55% <100.00%> (+0.03%) ⬆️
scapy/layers/windows/erref.py 100.00% <ø> (ø)
scapy/modules/ticketer.py 46.27% <71.42%> (+0.26%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 force-pushed the other-fixes branch 2 times, most recently from 6738423 to 6853c50 Compare June 29, 2026 19:10
- Ticketer: bad timezone conversions, improve handling of
  PAC_CLIENT_INFO when editing a ticket
- kerberos: support new error type when a password change is necessary
- DNS: handle case where a weird payload is returned

AI-Assisted: no
AI-Assisted: no
@gpotter2 gpotter2 merged commit 8c7ccdf into secdev:master Jun 29, 2026
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant