Skip to content

Kerberos & WinSSP: support KDC pinning, begin delegation#5028

Merged
gpotter2 merged 2 commits into
secdev:masterfrom
gpotter2:other-fixes
Jun 30, 2026
Merged

Kerberos & WinSSP: support KDC pinning, begin delegation#5028
gpotter2 merged 2 commits into
secdev:masterfrom
gpotter2:other-fixes

Conversation

@gpotter2

Copy link
Copy Markdown
Member
  • support KDC pinning on WinSSP. When testing in a CI environment with multiple KDCs, it allows to prevent replication races by always using the same DC
  • begin work to add GSS_C_DELEG_FLAG

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.88889% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.29%. Comparing base (8c7ccdf) to head (68f66ad).

Files with missing lines Patch % Lines
scapy/arch/windows/sspi.py 38.09% 52 Missing ⚠️
scapy/modules/ticketer.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5028      +/-   ##
==========================================
- Coverage   80.34%   80.29%   -0.05%     
==========================================
  Files         386      386              
  Lines       96037    96127      +90     
==========================================
+ Hits        77158    77188      +30     
- Misses      18879    18939      +60     
Files with missing lines Coverage Δ
scapy/modules/ticketer.py 46.30% <50.00%> (+0.02%) ⬆️
scapy/arch/windows/sspi.py 64.41% <38.09%> (-5.92%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gpotter2 added 2 commits June 30, 2026 03:13
Pinning / Unpinning the KDC is super useful in domains with multiple
KDCs.

AI-Assisted: no
We need to be able to make a KRB_CRED to delegate tickets using GSS_C_DELEG_FLAG

AI-Assisted: no
@gpotter2 gpotter2 merged commit 5f271b5 into secdev:master Jun 30, 2026
23 of 25 checks passed
@gpotter2 gpotter2 deleted the other-fixes branch June 30, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant