Add 802.11 HE Operation Info#5029
Open
middleendian wants to merge 2 commits into
Open
Conversation
added 2 commits
June 29, 2026 14:51
- 802.11ax-2021 9.4.2.249 - Add unit test AI-Assisted: yes (Codex)
gpotter2
reviewed
Jul 1, 2026
|
|
||
| length = orb(_pkt[1]) | ||
| ext_id = orb(_pkt[2]) | ||
| if ext_id == 36 and length >= 7: |
Member
There was a problem hiding this comment.
You should be able to use a dictionary that is automatically registered based on the subclasses ext_ID. Like what was done in
Lines 1059 to 1074 in fda6032
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-Assisted: yes (Codex)
PR 0001: Dot11 Element ID Extension and HE Operation
Scope:
Dot11EltExtensiondispatch for Element ID255.Dot11EltExtensionGenericfor unknown or unsupported extension IDs.Dot11EltHEOperationfor Extended ID36.Dot11HE6GOperationInfowhen the HE Operation element indicates that6 GHz operation information is present.
test/scapy/layers/dot11.utstests for generic, short, HE, andHE 6 GHz extended elements.
Spec references used in code comments:
9.4.2.1and Table9-92: Element ID Extension.9.4.2.249: HE Operation element.9-788k: 6 GHz Operation Information field.Intentional partial support:
patch does not try to implement all of them.
Dot11EltExtensionGeneric.first PR is reviewable on its own.
Focused test command used:
Result:
Full dot11 suite note:
test/scapy/layers/dot11.utsrun reached and passed the existingtests up through
Dot11EltVHTOperation in isolationbefore I interrupted itin this local environment because it was taking longer than expected.
The focused tests for this patch passed.