Skip to content

Return in finally block w/ Python 3.14 #516

Description

@JohnStrunk

When trying to upgrade my application from Python 3.13.7 -> 3.14.0, I encounter the following:

wh_analytics.py:30: in <module>
    from segment import analytics  # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.venv\Lib\site-packages\segment\analytics\__init__.py:3: in <module>
    from segment.analytics.client import Client
.venv\Lib\site-packages\segment\analytics\client.py:9: in <module>
    from segment.analytics.oauth_manager import OauthManager
.venv\Lib\site-packages\segment\analytics\oauth_manager.py:11: in <module>
    from segment.analytics.consumer import FatalError
E     File "D:\a\wahoo-results\wahoo-results\.venv\Lib\site-packages\segment\analytics\consumer.py", line 84
E       return success
E       ^^^^^^^^^^^^^^
E   SyntaxError: 'return' in a 'finally' block

See: https://docs.python.org/3/whatsnew/3.14.html#whatsnew314-finally-syntaxwarning

Technically, it is just a warning in 3.14.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions