Backport release/v6.7: Upgrade UCI AI review to latest and allow review of PRs from seidroid - #4063
Conversation
…#4059) Upgrade to the latest UCI version for AI review and comments, which most notably: reduces cancellation noise further, and optionally allows review of PRs created by non-humans. This repo will only accept PRs created by `seidroid`. Note that the only CI workflow that allows seidroid to create PRs is auto backporting workflow. (cherry picked from commit 0846501)
PR SummaryLow Risk Overview AI Review also passes Reviewed by Cursor Bugbot for commit a0cbdbc. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v6.7 #4063 +/- ##
================================================
- Coverage 61.34% 60.30% -1.04%
================================================
Files 2163 2064 -99
Lines 188889 177206 -11683
================================================
- Hits 115868 106869 -8999
+ Misses 62286 60545 -1741
+ Partials 10735 9792 -943
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Testing here since this is a bot authored PR. See: sei-protocol/uci#69
|
@seidroid review |
There was a problem hiding this comment.
Straightforward backport that bumps the UCI reusable-workflow pins and adds allowed-bots: '["seidroid[bot]"]' so AI review runs on automated backport PRs; both workflow refs remain SHA-pinned and the trigger set is unchanged. No blocking issues — only a note that this backport pins v0.0.21 while the source PR pinned v0.0.20, and that allowed-bots was added to the review workflow but not the assistant workflow.
Findings: 0 blocking | 2 non-blocking | 0 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- [suggestion] This backport deviates from its source PR (#4059), which pinned UCI v0.0.20 (
68010d0ab76554da91c320511fb14a7af1af4245); here both workflows are pinned to v0.0.21 (93ebad0186c8b71a4036fd0915ffe2ec44283d4b). That leavesrelease/v6.7running a UCI revisionmaindoes not use, so the two branches' AI review/assist behavior can drift and a regression in v0.0.21 would surface first on the release branch. Consider bumpingmainto v0.0.21 as well (or backporting v0.0.20 verbatim) so the pins stay in lockstep. - [suggestion]
allowed-botsis added only toai-review.yml, not toai-assist.yml, which keepsallowed-teamas its sole gate. If that asymmetry is intentional (assist is comment-driven and seidroid[bot] does not issue assistant commands), it is fine as-is; if backported PRs are also meant to be usable with the assistant, the same input is needed there.
Backport of #4059 and #4067 to
release/v6.7.