docs: update the reserved attribute name characters in the upgrade guide - #846
Draft
wikirik-agent wants to merge 1 commit into
Draft
wikirik-agent wants to merge 1 commit into
wikirik-agent wants to merge 1 commit into
Conversation
Companion of sequelize/sequelize#18461: attribute names now reject $, ., :, [, ] and control characters anywhere, and accept any other character (dashes, spaces, quotes, non-ASCII). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Companion of sequelize/sequelize#18461, which makes the attribute syntax parser and the model attribute-name validator share one reserved set:
$,.,:,[,]and control characters. Any other character (dashes, spaces, quotes, non-ASCII) is accepted in attribute names and usable inwhere/sql.attribute().This updates the "Attribute names cannot use syntax reserved by Sequelize" section of the upgrade guide accordingly. Draft until the core PR is merged.
🤖 Generated with Claude Code