Fixing flaky scheduler test#1411
Merged
fjtirado merged 1 commit intoMay 29, 2026
Merged
Conversation
There was an implicit race condition between the start().join() and the scheduledInstances() Signed-off-by: fjtirado <ftirados@redhat.com>
fjtirado
force-pushed
the
Fixing_flaky_scheduler_test
branch
from
45a11f5 to
99f2926
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky scheduler test by removing a race between workflow completion and the assertion on scheduled instances.
Changes:
- Creates the workflow instance before starting it.
- Moves the empty scheduled-instance assertion to occur before
start().join(). - Starts the instance afterward and continues awaiting the scheduled instance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an implicit race condition between the start().join() and the scheduledInstances()