Fix Cargo manual_readme warning - #608
Merged
alejandro-vaz merged 1 commit intoSep 13, 2026
Merged
Conversation
alejandro-vaz
self-requested a review
September 13, 2026 13:13
alejandro-vaz
approved these changes
Sep 13, 2026
Collaborator
|
thanks for contributing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #606.
Removes the explicit
package.readme = "README.md"entry from the v1 manifest. Cargo already infers the same README, so this removes the nightlycargo::manual_readmewarning without changing the package metadata.Validation:
cargo +nightly check: reproduced the warning before the change; nomanual_readmewarning after itREADME.mdas the package readmecargo test: 64 unit tests, 1 integration test, and 14 doctests passedcargo +nightly test --all-features: 74 unit tests, 1 integration test, and 19 doctests passedgit diff --checkpassed