Repository navigation
changed ptr to pointer - #845
Closed
pavanpannati wants to merge 0 commit into
Closed
pavanpannati wants to merge 0 commit into
pavanpannati wants to merge 0 commit into
Conversation
alejandro-vaz
self-requested a review
November 1, 2026 12:44
alejandro-vaz
requested changes
Nov 1, 2026
alejandro-vaz
left a comment
alejandro-vaz
left a comment
Collaborator
There was a problem hiding this comment.
and so on.
also, why is it called pointernternter??
| core::{ | ||
| alloc::Layout, | ||
| ptr::NonNull | ||
| pointernternter::NonNull |
Collaborator
There was a problem hiding this comment.
this has to stay as it was because it is an import from core
| core::{ | ||
| alloc::Layout, | ||
| ptr::NonNull | ||
| pointernternter::NonNull |
| core::{ | ||
| alloc::Layout, | ||
| ptr::NonNull | ||
| pointernternter::NonNull |
| use core::{ | ||
| alloc::Layout, | ||
| ptr::NonNull | ||
| pointernternter::NonNull |
| core::{ | ||
| alloc::Layout, | ||
| ptr::NonNull | ||
| pointernternter::NonNull |
alejandro-vaz
requested changes
Nov 1, 2026
alejandro-vaz
left a comment
alejandro-vaz
left a comment
Collaborator
There was a problem hiding this comment.
same thing. all use block should have ptr
all the others should have pointer
Author
|
once look into the last commit and inform me about the status, i hope i resolved the issue |
GauravPawar101
suggested changes
Nov 2, 2026
| @@ -0,0 +1,274 @@ | |||
| [33m3f02b6e[m[33m ([m[1;36mHEAD[m[33m -> [m[1;32mv2[m[33m, [m[1;31morigin/v2[m[33m, [m[1;31morigin/HEAD[m[33m)[m closed pointernternter error | |||
Collaborator
|
Also re-request review(rightside of your pr body ) after pushing changes @pavanpannati |
alejandro-vaz
requested changes
Nov 2, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #843