Repository navigation
Bump version to 1.33.6 (454) - #2235
Merged
Merged
Conversation
1.34.0 was cancelled and its changes ship as a patch instead. The code stays above 453, which the cancelled 1.34.0 used (Play 4531-4535).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.34.0 was cancelled, and its changes ship as the 1.33.6 patch instead.
canonicalVersionName1.34.0 → 1.33.6canonicalVersionCode453 → 454. 1.34.0 used 453 (Play 4531–4535), so the code keeps rising.Built
assemblePlayQa -PsplitApks=trueat3c967f67c5. versionCodes are 4541 (armeabi-v7a), 4542 (arm64-v8a), 4543 (x86), 4544 (x86_64) and 4545 (universal), all named 1.33.6.When cutting the release branch,
scripts/prepare-release.pyforks frommaster(1.33.4, code 451) by default, so pass--version-code 454.