Skip to content

fix: run on Python 3.11, which the ops host has #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bilb merged 1 commit into from
Oct 3, 2026
Merged

fix: run on Python 3.11, which the ops host has #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@ jobs:
steps:
- uses: actions/checkout@v7

# The oldest Python the deploy targets: Debian 12's.
- uses: actions/setup-python@v6
with:
python-version: "3.12"
python-version: "3.11"

- run: pip install uv==0.12.19

Expand Down
2 changes: 1 addition & 1 deletion deploy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ run under its `runs/` for 14 days.

## Install

Needs systemd 252+, Python 3.12+ at `/usr/bin/python3`, `git`, and nginx with certbot.
Needs systemd 252+, Python 3.11+ at `/usr/bin/python3`, `git`, and nginx with certbot.
As root:

```bash
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "session-ops"
version = "0.1.0"
description = "Session Foundation's scheduled jobs and webhooks: Zendesk, GitHub, Crowdin, SOGS."
readme = "README.md"
requires-python = ">=3.12"
requires-python = ">=3.11"
dependencies = [
# CLDR data: a new babel can rename a language in the generated language lists.
"babel==2.17.0",
Expand Down Expand Up @@ -47,7 +47,7 @@ build-backend = "uv_build"

# Pyflakes and syntax errors only: what catches a broken import or name mid-refactor.
[tool.ruff]
target-version = "py312"
target-version = "py311"

[tool.ruff.lint]
select = ["F", "E9"]
4 changes: 2 additions & 2 deletions src/session_ops/crowdin/download_translations_from_crowdin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ def export_and_download_language(language: dict, is_source: bool = False) -> str

with progress_lock:
completed_count += 1
print(f"\033[2K{Fore.WHITE}⏳ Downloaded {
completed_count}/{total_count} translations...{Style.RESET_ALL}", end='\r')
print(f"\033[2K{Fore.WHITE}⏳ Downloaded {completed_count}/{total_count} "
f"translations...{Style.RESET_ALL}", end='\r')

return lang_locale

Expand Down
3 changes: 1 addition & 2 deletions src/session_ops/crowdin/generate_shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,7 @@ def setup_generation(input_directory: str):
target_languages: List[str] = project_details['data']['targetLanguages']
target_languages.sort(key=lambda x: x['locale'])
num_languages = len(target_languages)
print_success(f"Project info processed, {
num_languages} languages will be converted")
print_success(f"Project info processed, {num_languages} languages will be converted")

rtl_languages: List[str] = [
lang for lang in target_languages if is_rtl(lang)]
Expand Down
54 changes: 18 additions & 36 deletions src/session_ops/crowdin/parse_xliff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,7 @@ def find_invalid_braces(text: str) -> List[str]:
# Check if content is a valid variable name (alphanumeric + underscore)
if not re.match(r'^\w+$', content):
snippet = text[i:end+1]
issues.append(f"Invalid variable syntax '{
snippet}' at position {i}")
issues.append(f"Invalid variable syntax '{snippet}' at position {i}")

i = end + 1
elif text[i] == '}':
Expand Down Expand Up @@ -236,8 +235,7 @@ def validate_all_translations(parsed_locales: Dict[str, Any], source_locale: str
string_values = get_all_string_values(trans_data)

for context, text in string_values:
full_key = f"{key}" if context == "value" else f"{
key} ({context})"
full_key = f"{key}" if context == "value" else f"{key} ({context})"

# Check 1: Variables match source (NON-PLURALS ONLY)
# Plurals are skipped because different languages have different plural forms
Expand All @@ -251,15 +249,13 @@ def validate_all_translations(parsed_locales: Dict[str, Any], source_locale: str
if missing_vars:
result.add_issue(
locale, full_key, "missing_variable",
f"Missing variables: {{{
', '.join(sorted(missing_vars))}}}"
f"Missing variables: {{{', '.join(sorted(missing_vars))}}}"
)

if extra_vars:
result.add_issue(
locale, full_key, "extra_variable",
f"Extra variables not in source: {{{
', '.join(sorted(extra_vars))}}}"
f"Extra variables not in source: {{{', '.join(sorted(extra_vars))}}}"
)

# Check 3: Invalid curly braces (ALL strings including plurals)
Expand Down Expand Up @@ -297,8 +293,7 @@ def validate_all_translations(parsed_locales: Dict[str, Any], source_locale: str
if locale_count < source_count:
result.add_issue(
locale, full_key, "missing_tag",
f"Missing <{tag}> tags: expected {
source_count}, found {locale_count}",
f"Missing <{tag}> tags: expected {source_count}, found {locale_count}",
severity="warning"
)

Expand All @@ -324,11 +319,9 @@ def print_validation_summary(result: ValidationResult):

type_display = issue_type.replace('_', ' ').title()
if error_issues:
print(f"{Fore.RED} {type_display}: {
len(error_issues)} errors{Style.RESET_ALL}")
print(f"{Fore.RED} {type_display}: {len(error_issues)} errors{Style.RESET_ALL}")
if warning_issues:
print(f"{Fore.YELLOW} {type_display}: {
len(warning_issues)} warnings{Style.RESET_ALL}")
print(f"{Fore.YELLOW} {type_display}: {len(warning_issues)} warnings{Style.RESET_ALL}")

print(f"\n{Fore.YELLOW}Issues by locale:{Style.RESET_ALL}")
by_locale = result.get_issues_by_locale()
Expand All @@ -350,10 +343,8 @@ def print_validation_summary(result: ValidationResult):
print(f" ... and {len(issues) - 3} more")

print(f"\n{Fore.YELLOW}{'='*60}{Style.RESET_ALL}")
total_str = f"{Fore.RED}{error_count} errors{
Style.RESET_ALL}" if error_count else ""
warning_str = f"{Fore.YELLOW}{warning_count} warnings{
Style.RESET_ALL}" if warning_count else ""
total_str = f"{Fore.RED}{error_count} errors{Style.RESET_ALL}" if error_count else ""
warning_str = f"{Fore.YELLOW}{warning_count} warnings{Style.RESET_ALL}" if warning_count else ""
print(f"Total: {', '.join(filter(None, [total_str, warning_str]))}")
print(f"{Fore.YELLOW}{'='*60}{Style.RESET_ALL}\n")

Expand Down Expand Up @@ -476,8 +467,7 @@ def parse_all_xliff_files(input_directory: str, skip_validation: bool = False) -
raise FileNotFoundError(
f"Could not find '{input_file}' in raw translations directory")

print(f"\033[2K{Fore.WHITE}⏳ Parsing {
lang_locale}...{Style.RESET_ALL}", end='\r')
print(f"\033[2K{Fore.WHITE}⏳ Parsing {lang_locale}...{Style.RESET_ALL}", end='\r')

try:
result = parse_xliff_file(input_file)
Expand All @@ -491,24 +481,20 @@ def parse_all_xliff_files(input_directory: str, skip_validation: bool = False) -
}

except Exception as e:
raise ValueError(f"Error processing locale {
lang_locale}: {str(e)}")
raise ValueError(f"Error processing locale {lang_locale}: {str(e)}")

print(f"\033[2K{Fore.GREEN}✅ Parsed {
len(parsed_locales)} locale files{Style.RESET_ALL}")
print(f"\033[2K{Fore.GREEN}✅ Parsed {len(parsed_locales)} locale files{Style.RESET_ALL}")

# Run validation
validation_result = ValidationResult()
if not skip_validation:
print(f"{Fore.WHITE}⏳ Validating translations...{
Style.RESET_ALL}", end='\r')
print(f"{Fore.WHITE}⏳ Validating translations...{Style.RESET_ALL}", end='\r')
source_locale = source_language['locale']
validation_result = validate_all_translations(
parsed_locales, source_locale)

if validation_result.issues:
print(f"\033[2K{Fore.YELLOW}⚠️ Validation completed with issues{
Style.RESET_ALL}")
print(f"\033[2K{Fore.YELLOW}⚠️ Validation completed with issues{Style.RESET_ALL}")
else:
print(f"\033[2K{Fore.GREEN}✅ Validation passed{Style.RESET_ALL}")

Expand Down Expand Up @@ -579,28 +565,24 @@ def main(argv=None):
or '.', exist_ok=True)
with open(args.validation_report, 'w', encoding='utf-8') as f:
json.dump(report, f, ensure_ascii=False, indent=2)
print(f"{Fore.WHITE}Validation report saved to {
args.validation_report}{Style.RESET_ALL}")
print(f"{Fore.WHITE}Validation report saved to {args.validation_report}{Style.RESET_ALL}")

os.makedirs(os.path.dirname(args.output_file) or '.', exist_ok=True)
with open(args.output_file, 'w', encoding='utf-8') as f:
json.dump(parsed_data, f, ensure_ascii=False, indent=2)

print(f"{Fore.GREEN}✅ Parsed translations saved to {
args.output_file}{Style.RESET_ALL}")
print(f"{Fore.GREEN}✅ Parsed translations saved to {args.output_file}{Style.RESET_ALL}")

if args.error_on_validation_failure and validation_result.has_errors():
print(f"{Fore.RED}❌ Exiting with error due to validation failures{
Style.RESET_ALL}")
print(f"{Fore.RED}❌ Exiting with error due to validation failures{Style.RESET_ALL}")
sys.exit(f"{validation_result.get_error_count()} translation(s) failed "
f"validation; see the validation report")

except KeyboardInterrupt:
print("\nProcess interrupted by user")
sys.exit(0)
except Exception as e:
print(f"\033[2K{Fore.RED}❌ An error occurred: {
str(e)}{Style.RESET_ALL}")
print(f"\033[2K{Fore.RED}❌ An error occurred: {str(e)}{Style.RESET_ALL}")
sys.exit(f"Parsing the translations failed: {e}")


Expand Down
Loading
Loading