Skip to content

added toolbar button#558

Open
dplewinska wants to merge 1 commit into
shlomif:masterfrom
dplewinska:add-deal-button
Open

added toolbar button#558
dplewinska wants to merge 1 commit into
shlomif:masterfrom
dplewinska:add-deal-button

Conversation

@dplewinska
Copy link
Copy Markdown
Contributor

issue #391

@joeraz
Copy link
Copy Markdown
Collaborator

joeraz commented Feb 19, 2026

The button works. However, it remains enabled if the deal cards option is not currently allowed, while the menu item is grayed out and the talon is either blocked or not present.

Also, I am not a fan of having one button with no icon. I've got the icon libraries set aside locally, and can review to add one.

@shlomif
Copy link
Copy Markdown
Owner

shlomif commented May 24, 2026

@dplewinska @joeraz : any update?

@joeraz
Copy link
Copy Markdown
Collaborator

joeraz commented May 24, 2026

No further updates - there are still two reasons I did not merge this PR:

  • The button is always enabled, and not enabled/disabled the way the corresponding main menu item is.
  • The button does not have an icon, which gives it an inconsistent UI from the remaining buttons - I could add something with the icon libraries I have myself, but would need to figure out which icon to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants