(just for running checks)#159
Closed
imnasnainaec wants to merge 8 commits into
Closed
Conversation
Exclude the "Open Interlinearizer" project-picker tab from the four broad .dock-tab matches (ensureInterlinearizerOpenOnWeb, isDraftDirty, closeInterlinearizerTab, rescueDraftToNewProject) so they target the real WebView tab. Also anchor the active-project check in ensureE2eProjectActive to match E2E_PROJECT_NAME exactly instead of via unanchored includes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The e2e feature helpers couldn't reliably pass on the shared CDP
instance:
- ensureE2eProjectActive matched the project entry by the button's
accessible
name, but the modal renders name/badge/language spans with no
separating
whitespace, so the anchored regex never matched — every mutating test
fell
into the create branch and re-created an existing project. Match the
name
element by exact text instead (also fixes the "E2E Test Project 2"
overmatch).
- The create branch hung on a dirty draft (Create defers behind the
discard
confirm); dismiss it when dirty.
- closeInterlinearizerTab used hover()+click(), which times out when the
tab
overflows off-viewport on CI; use dispatchEvent('click') like
paranext-core.
- ensureInterlinearizerOpenOnWeb settles the dock before its isVisible()
branch.
- Extract interlinearizerTabLocator/escapeRegExp helpers.
The tab's unsaved marker used dirty||pendingEdits but ProjectModals
gated its
discard confirmation on committed dirty only, so opening/creating a
project
mid-typing silently discarded the uncommitted gloss. Rename the prop to
hasUnsavedWork and feed it the combined state so the guard and marker
agree.
Document the broadened discard-on-swap behavior in user-questions.md.
globalSetup now launches and tears down its own Platform.Bible instance (reusing a warm start:cdp when the CDP port is in use), and .or() tab waits get .first() so a docked Interlinearizer + WEB tab no longer trip Playwright strict mode.
Kill the CDP app's whole process tree (taskkill /T /F on Windows, POSIX process-group SIGKILL elsewhere) so no orphans hold port 8876, and stream the launched app's output to a log instead of discarding it, so a startup crash shows its cause rather than an opaque WebSocket-port timeout.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is