Pass stable data dir to FW Lite to survive extension version updates#2385
Conversation
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hahn-kev
left a comment
hahn-kev
left a comment
There was a problem hiding this comment.
this looks correct to me
imnasnainaec
force-pushed
the
pb-ext-stable-data-path
branch
from
0fb240f to
db851ab
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Platform.Bible runs each extension version from a versioned cache directory, so FW Lite's default of storing projects and auth cache relative to its binary would orphan data on every update. Pass explicit paths rooted at ~/.platform.bible/extensions/lexicon/ to keep data stable across versions. Closes #2351 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Platform.Bible actively rejects require() calls for non-papi modules at runtime. Replace fs/os/path imports with process.env globals (which are Node.js globals, not requires) and remove the pre-launch mkdirSync (FW Lite creates its own data directories). Also reverts the incorrect webpack externals change that made the build succeed but not the runtime. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
imnasnainaec
force-pushed
the
pb-ext-stable-data-path
branch
from
db851ab to
b1875e5
Compare
- Nest under a fw-lite subfolder so it doesn't share extensions/lexicon with Platform.Bible's own papi.storage user-data for this extension. - Mirror dev vs. packaged app:// resolution (paranext-core's getAppDir) so `npm start` uses dev-appdata instead of the real per-user location. - Throw on missing USERPROFILE instead of silently building a drive-relative path; drop the dead HOME fallback (win32 is already guaranteed by the time this runs). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 participants
Platform.Bible runs each extension version from a versioned cache directory, so FW Lite's default of storing projects and auth cache relative to its binary would orphan data on every update. Pass explicit paths rooted at
~/.platform.bible/extensions/lexicon/to keep data stable across versions.Closes #2351
Devin: https://app.devin.ai/review/sillsdev/languageforge-lexbox/pull/2385