Fix _decode_default_value to unescape doubled single quotes in string defaults#811
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix _decode_default_value to unescape doubled single quotes in string defaults#811ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
… defaults SQLite stores string defaults with single quotes doubled (e.g. DEFAULT 'O''Brien' is stored as the literal "'O''Brien'" in sqlite_master). The previous code stripped the outer quotes with value[1:-1] but never converted '' back to ', so default_values returned the raw escaped form instead of the true string value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite stores string defaults with single quotes doubled (e.g.
DEFAULT 'O''Brien'is stored as'O''Brien'insqlite_master). The_decode_default_valuefunction stripped the outer quotes correctly but never unescaped''back to', sotable.default_valuesreturned the raw escaped form instead of the actual string value. The fix adds.replace("''", "'")after stripping the outer quotes.Generated by Claude Code
📚 Documentation preview 📚: https://sqlite-utils--811.org.readthedocs.build/en/811/