Fix KeyError when passing an unrecognized string type to create_table or add_column - #818
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix KeyError when passing an unrecognized string type to create_table or add_column#818ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
… or add_column Passing a valid SQLite type string that is not in COLUMN_TYPE_MAPPING, such as NUMERIC or ANY, raised KeyError instead of being used as-is. The fix falls back to the raw string value when the type is a string not present in the mapping, matching the documented behaviour: col_type accepts Python types or SQLite type strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a valid SQLite type string not present in
COLUMN_TYPE_MAPPING— such as"NUMERIC"or"ANY"— tocreate_tableoradd_columnraisesKeyErrorinstead of using the string as-is. The documentation for both methods explicitly states thatcol_typeaccepts "a Python type such asstror a SQLite type string such asBLOB", so any string should be accepted and passed through to SQLite unchanged. The fix uses.get()on the mapping and falls back to the raw string when the type is an unrecognised string, leaving all existing behaviour unchanged.Generated by Claude Code
📚 Documentation preview 📚: https://sqlite-utils--818.org.readthedocs.build/en/818/