fix(platform): hide controls a viewer cannot use instead of disabling them unexplained

New documents shows only to an editor, as New connector beside it does;
Create fork only to someone who can fork; and the sidebar's Add workspace
only when the organization lets this viewer create one, since an
icon button cannot explain why it is off.

Author: waleedlatif1

apps/sim/app/(product)/_components/sidebar/workspaces-section.tsx

@@ -82,8 +82,6 @@ export function WorkspacesSection({
     ]
   }
 
-  const addLabel = canCreate ? 'Add workspace' : (policy?.reason ?? CREATE_UNAVAILABLE)
-
   return (
     <>
       <Disclosure
@@ -98,13 +96,12 @@ export function WorkspacesSection({
               order={workspaceOrder}
               onChange={setWorkspaceOrder}
             />
-            {create && (
+            {create && canCreate && (
               <IconButton
                 tooltip
                 size='compact'
-                label={addLabel}
+                label='Add workspace'
                 icon='I074'
-                disabled={!canCreate}
                 onClick={() => actions.requestLeave(() => setCreating(true))}
               />
             )}

apps/sim/app/(product)/_components/workspace/knowledge/knowledge-base/knowledge-base.tsx

@@ -619,15 +619,17 @@ export function KnowledgeBase({ workspaceId, knowledgeBaseId }: KnowledgeBasePro
           New connector
         </Button>
       )}
-      <Button
-        variant='secondary'
-        size='compact'
-        icon='I117'
-        disabled={!canEdit}
-        onClick={() => setUploading(true)}
-      >
-        New documents
-      </Button>
+      {(canEdit || access.isLoading) && (
+        <Button
+          variant='secondary'
+          size='compact'
+          icon='I117'
+          disabled={!canEdit}
+          onClick={() => setUploading(true)}
+        >
+          New documents
+        </Button>
+      )}
     </ControlBar>
   )
 

apps/sim/app/(product)/workspace/[workspaceId]/settings/_components/sections/forks/forks-section.tsx

@@ -239,17 +239,18 @@ export default function ForksSection({ workspaceId }: WorkspaceSettingsSectionPr
                   description={query ? undefined : 'Create a fork to get started.'}
                 />
               )}
-              <SettingsRow label='New fork'>
-                <Button
-                  variant='primary'
-                  size='compact'
-                  icon='I074'
-                  disabled={!canMutate}
-                  onClick={() => setForking(true)}
-                >
-                  Create fork
-                </Button>
-              </SettingsRow>
+              {canMutate && (
+                <SettingsRow label='New fork'>
+                  <Button
+                    variant='primary'
+                    size='compact'
+                    icon='I074'
+                    onClick={() => setForking(true)}
+                  >
+                    Create fork
+                  </Button>
+                </SettingsRow>
+              )}
             </SettingsSection>
             <SettingsSection title='Synced workflows'>
               {/* Only this workspace's own value: a previous workspace's placeholder would write another lineage's policy. */}

apps/sim/platform/checks/live/shell.spec.ts

@@ -117,7 +117,7 @@ test('creating a workspace opens it in the zone, on its Workflows tab', async ({
       .getByRole('button', { name: 'Add workspace' })
       .click()
     await page.getByRole('textbox', { name: 'Workspace name' }).fill(name)
-    await page.getByRole('button', { name: 'Create', exact: true }).click()
+    await page.getByRole('button', { name: 'Create workspace', exact: true }).click()
     await expect(page).toHaveURL(/\/workspace\/[^/]+\/workflows/)
   } finally {
     // Every later check reads the seeded organization's workspaces, and a rerun would list two.