Skip to content

fix(security): resolve ReDoS vulnerability in function execute tag pattern #4149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
Apr 14, 2026
Merged

fix(security): resolve ReDoS vulnerability in function execute tag pattern #4149

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6073770
fix(security): resolve ReDoS vulnerability in function execute tag pa…
waleedlatif1 Apr 14, 2026
28f3401
fix(security): exclude trailing-dot refs and hoist tag pattern to mod…
waleedlatif1 Apr 14, 2026
dc41251
fix(security): align tag pattern with codebase standard [^<>]+ pattern
waleedlatif1 Apr 14, 2026
4e21a08
refactor(security): use createReferencePattern() instead of inline regex
waleedlatif1 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions apps/sim/app/api/function/execute/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ export const MAX_DURATION = 210

const logger = createLogger('FunctionExecuteAPI')

const TAG_PATTERN = new RegExp(
`${REFERENCE.START}([^${REFERENCE.START}${REFERENCE.END}]+)${REFERENCE.END}`,
'g'
)
Comment thread
waleedlatif1 marked this conversation as resolved.
Outdated
Comment thread
waleedlatif1 marked this conversation as resolved.
Outdated

const E2B_JS_WRAPPER_LINES = 3
const E2B_PYTHON_WRAPPER_LINES = 1

Expand Down Expand Up @@ -493,11 +498,7 @@ function resolveTagVariables(
let resolvedCode = code
const undefinedLiteral = language === 'python' ? 'None' : 'undefined'

const tagPattern = new RegExp(
`${REFERENCE.START}([a-zA-Z_](?:[a-zA-Z0-9_${REFERENCE.PATH_DELIMITER}]*[a-zA-Z0-9_])?)${REFERENCE.END}`,
'g'
)
const tagMatches = resolvedCode.match(tagPattern) || []
const tagMatches = resolvedCode.match(TAG_PATTERN) || []

for (const match of tagMatches) {
const tagName = match.slice(REFERENCE.START.length, -REFERENCE.END.length).trim()
Expand Down
Loading