Skip to content

fix(ci): replace dynamic secret access with explicit secret references #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Apr 14, 2026
+14 −2
Merged

fix(ci): replace dynamic secret access with explicit secret references #4151

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d93ac7
fix(ci): replace dynamic secret access with explicit secret references
waleedlatif1 Apr 14, 2026
830454b
fix(ci): add explicit ECR_REALTIME guard and use env block for secret…
waleedlatif1 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,20 @@ jobs:
- name: Set up Docker Buildx
uses: useblacksmith/setup-docker-builder@v1

- name: Resolve ECR repo name
id: ecr-repo
run: echo "name=$ECR_REPO" >> $GITHUB_OUTPUT
env:
ECR_REPO: ${{ matrix.ecr_repo_secret == 'ECR_APP' && secrets.ECR_APP || matrix.ecr_repo_secret == 'ECR_MIGRATIONS' && secrets.ECR_MIGRATIONS || secrets.ECR_REALTIME }}
Comment thread
waleedlatif1 marked this conversation as resolved.
Outdated

- name: Build and push
uses: useblacksmith/build-push-action@v2
with:
context: .
file: ${{ matrix.dockerfile }}
platforms: linux/amd64
push: true
tags: ${{ steps.login-ecr.outputs.registry }}/${{ secrets[matrix.ecr_repo_secret] }}:dev
tags: ${{ steps.login-ecr.outputs.registry }}/${{ steps.ecr-repo.outputs.name }}:dev
provenance: false
sbom: false

Expand Down Expand Up @@ -159,7 +165,7 @@ jobs:
id: meta
run: |
ECR_REGISTRY="${{ steps.login-ecr.outputs.registry }}"
ECR_REPO="${{ secrets[matrix.ecr_repo_secret] }}"
ECR_REPO="${{ matrix.ecr_repo_secret == 'ECR_APP' && secrets.ECR_APP || matrix.ecr_repo_secret == 'ECR_MIGRATIONS' && secrets.ECR_MIGRATIONS || secrets.ECR_REALTIME }}"
Comment thread
waleedlatif1 marked this conversation as resolved.
Outdated
GHCR_IMAGE="${{ matrix.ghcr_image }}"

if [ "${{ github.ref }}" = "refs/heads/main" ]; then
Expand Down
Loading