-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat(setup): setup wizard with browser-based Chat key handoff #5911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheodoreSpeaks
wants to merge
17
commits into
staging
Choose a base branch
from
feat/cli-auth-key
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9a9132e
feat(setup): setup wizard with browser-based Chat key handoff
TheodoreSpeaks 090342c
improvement(setup): drop the paste-a-key fallback, simplify consent copy
TheodoreSpeaks af8ad44
fix(setup): pin kube context, keep secrets out of argv, validate reus…
TheodoreSpeaks 65e6ef1
refactor(copilot): one module for Chat API key operations
TheodoreSpeaks d362e68
improvement(setup): reuse shared helpers, parallelize probes, drop de…
TheodoreSpeaks 209e6ec
fix(setup): make doctor understand the compose env layout
TheodoreSpeaks 43de45d
feat(cli-auth): device-authorization poll flow, drop the loopback lis…
TheodoreSpeaks 08d13fa
fix(setup): reuse an existing managed Postgres container instead of c…
TheodoreSpeaks 9db7998
improvement(setup): audience-first run-mode hints
TheodoreSpeaks e00b02d
Merge remote-tracking branch 'origin/staging' into feat/cli-auth-key
TheodoreSpeaks 8e8c5ca
fix(cli-auth): retry a failed mint, port container/port fixes to Redi…
TheodoreSpeaks c5a6607
fix(setup): harden mint cleanup, Windows browser, container detection…
TheodoreSpeaks fd1a900
feat(chat-keys): standalone manage page, drop from settings nav, refr…
TheodoreSpeaks cb49a61
fix(setup): per-key reason in the secret-replacement warning
TheodoreSpeaks cf61a14
fix(setup): compose doctor schema, cross-platform binary detection, q…
TheodoreSpeaks a393319
fix(setup): quote kube-context in the helm uninstall tear-down hint too
TheodoreSpeaks f24f237
feat(setup): sim lifecycle CLI — start/stop/status/logs/down/reset
TheodoreSpeaks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /** | ||
| * Where the user goes once authentication finishes, carried across the login → | ||
| * signup → verify hops. Written only after `validateCallbackUrl` accepts it, and | ||
| * re-validated on read. | ||
| */ | ||
| export const POST_AUTH_REDIRECT_STORAGE_KEY = 'postAuthRedirectUrl' | ||
|
|
||
| interface AuthCrossLinkParams { | ||
| /** Validated post-auth destination to carry over, or null to drop it. */ | ||
| callbackUrl: string | null | ||
| isInviteFlow: boolean | ||
| } | ||
|
|
||
| /** | ||
| * Builds the login ⇄ signup cross-link, preserving the post-auth destination so | ||
| * a visitor who signs up instead of signing in still lands where they were | ||
| * headed. `URLSearchParams` does the encoding — a destination that carries its | ||
| * own query string (`/cli/auth?callback=…&state=…`) must survive intact. | ||
| */ | ||
| export function buildAuthCrossLink( | ||
| path: '/login' | '/signup', | ||
| { callbackUrl, isInviteFlow }: AuthCrossLinkParams | ||
| ): string { | ||
| const params = new URLSearchParams() | ||
| if (isInviteFlow) params.set('invite_flow', 'true') | ||
| if (callbackUrl) params.set('callbackUrl', callbackUrl) | ||
|
|
||
| const query = params.toString() | ||
| return query ? `${path}?${query}` : path | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.