Skip to content

fix(chat): sweep the text shimmer left-to-right#5926

Open
TheodoreSpeaks wants to merge 1 commit into
stagingfrom
fix/shimmer-sweep-direction
Open

fix(chat): sweep the text shimmer left-to-right#5926
TheodoreSpeaks wants to merge 1 commit into
stagingfrom
fix/shimmer-sweep-direction

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Drop the reverse from the shimmer-sweep animation in shimmer-text.module.css — the sweep runs right-to-left on staging
  • fix(chat): reverse shimmer sweep to left-to-right #5650 added reverse to flip the old keyframes (implicit 0% -> 200%, natively right-to-left) into a left-to-right sweep
  • feat(agent-stream): thinking and tool streaming #5671 then rewrote the keyframes to 100% -> -100%, which is already left-to-right, but left reverse in place — the two cancel out
  • Direction now lives in one place (the keyframes) instead of being split across the shorthand and the @keyframes block 10 lines apart
  • Affects every ShimmerText consumer: subagent labels and tool-call rows in chat, plus the agent-stream thinking chrome

Type of Change

  • Bug fix

Testing

Tested manually. bun run lint:check and bun run check:api-validation:strict pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

#5671 rewrote the shimmer-sweep keyframes to run 100% -> -100%, which is
already left-to-right, but left the `reverse` from #5650 on the animation
shorthand. The two flips cancel into a right-to-left sweep on every
ShimmerText consumer: subagent labels, tool-call rows, and the new
agent-stream thinking chrome.

Drop `reverse` so direction lives in exactly one place — the keyframes.
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 24, 2026 5:38pm

Request Review

@cursor

cursor Bot commented Jul 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single-line visual animation tweak in shared UI CSS with no logic, auth, or data impact.

Overview
Fixes the in-progress text shimmer so the highlight sweeps left-to-right again across all ShimmerText usages (chat subagent labels, tool-call rows, thinking chrome).

The shimmer-sweep animation no longer uses reverse. After an earlier keyframe rewrite (100%-100%), the sweep was already defined as left-to-right, but reverse was still applied and effectively flipped it back to right-to-left on staging. Direction is now controlled only by the @keyframes block.

Reviewed by Cursor Bugbot for commit 16879cc. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Fixes the shimmer animation direction by removing the stale reverse modifier, allowing the existing keyframes to sweep text left-to-right.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

The changed shorthand now plays the existing left-to-right keyframes normally, while reduced-motion behavior and all consumers remain unaffected.

Important Files Changed

Filename Overview
apps/sim/components/ui/shimmer-text.module.css Removes the animation reversal so the 100% to -100% keyframe progression renders in its intended left-to-right direction.

Reviews (1): Last reviewed commit: "fix(chat): sweep the text shimmer left-t..." | Re-trigger Greptile

@TheodoreSpeaks TheodoreSpeaks changed the title fix(chat): sweep the text shimmer left-to-right again fix(chat): sweep the text shimmer left-to-right Jul 24, 2026
@blacksmith-sh

blacksmith-sh Bot commented Jul 24, 2026

Copy link
Copy Markdown

Blacksmith runners detected OOM events on the following jobs:

Job Details
Test and Build / Build App View Job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant