fix(skills): show the new skill after creating it

[waleedlatif1]

Summary

• Creating a skill left you on /skills/new with the header still reading "New skill", the fields still filled, and no confirmation. The redirect was there but the unsaved-changes guard undid it: isDirty was derived from createSkill.isSuccess, so on success the guard's effect fired history.back() to pop its sentinel entry and cancelled the router.push that had just run.
• The guard now exposes release() to retire itself for the rest of the mount; the create page calls it before navigating with replace, so the sentinel entry is consumed instead of stacked and Back doesn't land on a stale empty form.
• Added a success toast on create — and on save, which was silent (create loud / save silent in the same feature was the only clearly wrong outcome).

Rest is from a cleanup pass over the same surfaces:

• useCreateSkill resolves the created row, so the page reads created.id instead of re-deriving it by name from the response list.
• Seed the list cache with the upsert's authoritative list verbatim — POST /api/skills returns the same listSkillsForUser payload as GET, and the old id-merge preserved the previous ordering, briefly rendering the new skill at the bottom of a createdAt desc list.
• Detail page treats placeholder data as loading. useSkills is workspace-scoped with keepPreviousData, so a workspace switch served another workspace's list as success-with-no-match and flashed "Skill not found." Matches the existing integration-skills-section.tsx precedent.
• Credential-detail drafts seed on id change instead of in a value-keyed effect, so a background refetch can't clobber an in-progress edit (or silently reset isDirty and pop the sentinel mid-edit).
• Toast on delete failure, which was fully silent.
• Delete navigates with replace and retires the guard, so Back can't return to the deleted skill's URL.

Type of Change

• Bug fix

Testing

Typecheck, bun run lint:check (19/19 packages), check:api-validation, and the skills test suite (22 tests) all pass. Not yet clicked through in a browser — the fix is reasoned from the history/effect ordering, so worth a manual pass on the deploy preview.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 25, 2026 2:12am

[cursor]

PR Summary

Low Risk
Client-side navigation, React Query cache, and UI polish in workspace skills/settings; no auth or server contract changes beyond using existing upsert responses.

Overview
Fixes skill create staying on /skills/new after success: the unsaved-changes guard no longer treats mutation success as “clean” (which popped the history sentinel and cancelled the pending redirect). useUnsavedChangesGuard now exposes release() / rearm() so callers can retire the trap before intentional navigation; create and delete use router.replace after release() so the seeded back entry is consumed instead of fighting navigation.

Skills UX and data: success toasts on create/save; delete failures surface a toast. useCreateSkill returns the created row and seeds the list cache from the upsert’s authoritative ordering (fixes brief wrong sort). Detail and custom-tools lists treat isPlaceholderData as loading to avoid false “not found” when switching workspaces. Optimistic delete keeps a loading state until navigation completes; failed delete rearms the guard.

UI cleanup: resource tile chrome is shared via RESOURCE_TILE_BASE / RESOURCE_TILE_FILL; SettingsResourceRow owns trailing flex-shrink-0 so list callers can drop redundant shrink classes. Minor skills list typography alignment; useUpdateSkill no longer invalidates the editors roster on content-only updates.

^{Reviewed by Cursor Bugbot for commit 6aad77e. Configure here.}

[greptile-apps]

Greptile Summary

This PR fixes skill creation and deletion navigation while improving related cache, loading, notification, draft, and shared resource-row behavior.

• Adds release/rearm lifecycle controls to the unsaved-changes guard and uses replacement navigation after creating or deleting a skill.
• Returns the newly created skill from the create mutation and refreshes the skills cache using the server-provided ordering.
• Treats workspace-scoped placeholder data as loading and keeps optimistic deletion transitions in a loading state.
• Adds success and failure notifications for skill mutations.
• Consolidates resource-tile styling and trailing-action sizing across workspace settings surfaces.

Confidence Score: 5/5

The PR appears safe to merge with no eligible blocking failures identified in this follow-up review.

No blocking failures remain.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/components/credential-detail/hooks/use-unsaved-changes-guard.ts	Adds explicit release and rearm controls while tracking whether the history sentinel is consumed during a released interval.
apps/sim/app/workspace/[workspaceId]/skills/new/skill-create.tsx	Navigates directly to the returned created skill after releasing the guard and displays a success notification.
apps/sim/app/workspace/[workspaceId]/skills/[skillId]/skill-detail.tsx	Improves workspace-transition loading, save/delete notifications, and optimistic-delete navigation handling.
apps/sim/hooks/queries/skills.ts	Returns the created skill from the mutation, preserves authoritative response ordering, and narrows member-query invalidation.
apps/sim/app/workspace/[workspaceId]/settings/components/settings-resource-row/settings-resource-row.tsx	Reuses shared tile styling and centrally prevents trailing controls from shrinking.

Sequence Diagram

sequenceDiagram
  participant User
  participant Page as Skill page
  participant Guard as Unsaved-change guard
  participant API as Skills API
  participant Router
  User->>Page: Create or delete skill
  Page->>Guard: release()
  Page->>API: Run mutation
  alt Mutation succeeds
    API-->>Page: Updated skill data
    Page->>Router: replace(destination)
  else Mutation fails after early release
    API-->>Page: Error
    Page->>Guard: rearm() when applicable
  end

Loading

_{Reviews (4): Last reviewed commit: "fix(skills): track a sentinel consumed w..." | Re-trigger Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 6aad77e. Configure here.}