Skip to content

fix(ci): bake the CLI telemetry token into the build that bun publish ships - #7790

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/cli-publish-telemetry-env
Sep 11, 2026
Merged

fix(ci): bake the CLI telemetry token into the build that bun publish ships#7790
waleedlatif1 merged 1 commit into
stagingfrom
fix/cli-publish-telemetry-env

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The published sim@2.1.15 has no reporting destination: bun publish runs prepublishOnly, which rebuilds dist after the "Build package" step, and that second build ran without SIM_CLI_TELEMETRY_* because the variables were scoped to the first step
  • Variables now sit at the job level so both builds see them

Type of Change

  • Bug fix

Testing

  • Verified the shipped 2.1.15 tarball still contains the raw process.env.SIM_CLI_TELEMETRY_KEY reads and reports "no reporting destination"; the publish run log shows the second bun build under bun publish
  • Locally, a build with the variable set inlines the token and reports "Usage reporting is on"

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 11, 2026 11:23pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge and correctly covers the artifact-producing publish lifecycle.

Summary

  • Ensures the prepublishOnly rebuild triggered by bun publish receives the telemetry destination.
  • Preserves the existing initial build while covering the artifact-producing publish lifecycle.
  • Introduces no dependency, application-code, or security-boundary changes.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Job[Publishing job environment] --> Initial[Initial bun run build]
  Job --> Publish[bun publish]
  Publish --> Lifecycle[prepublishOnly]
  Lifecycle --> Rebuild[bun run build]
  Rebuild --> Artifact[Published CLI with telemetry destination]
Loading

Reviews (1) · Last reviewed commit: "fix(ci): bake the CLI telemetry token in..."

@waleedlatif1
waleedlatif1 merged commit 29c604d into staging Sep 11, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/cli-publish-telemetry-env branch September 11, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant