Repository navigation
fix(next): align with route-handler framing in 16.4.5 and hash Bun patches into turbo tasks - #9822
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryThis PR updates SSE headers and makes patch edits affect Turbo task hashes.
Reviews (2) · Last reviewed commit: "fix(next): align with route-handler fram..." · Reviewed by Greptile |
…tches into turbo tasks
waleedlatif1
force-pushed
the
fix/next-framing-upstream
branch
from
November 9, 2026 23:35
0aa71b4 to
ea30ad2
Compare
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Length,Content-Encoding, andTransfer-Encodingfrom every Node route-handler response. Upstream keeps this deliberately: Automatically compress route handler responses if not already compressed vercel/next.js#101220 closed the scoped alternative (#101201) because afetch()response is indistinguishable from a synthetic one. This PR aligns with that instead of patching around it (fix(next): keep route-handler framing for bodies Next did not decode #9820, closed)SSE_HEADERSnow sendsCache-Control: no-cache, no-transform, and Chat'sSSE_RESPONSE_HEADERSdrops itsContent-Encoding: nonemarker, which 16.4.5 strips anyway.no-transformis the standard signal Next's bundledcompressionmiddleware and intermediaries honor, so streams stay unbuffered when route-handler compression arrives (16.4.6)Content-Lengthrequirement was relaxed separately in test(e2e): stop requiring Content-Length on streamed Route Handler downloads #9824turbo.jsonhashespatches/**into every task (globalDependencies).bun.lockrecords only a patch's path, so editing a Bun patch left every task hash unchanged and CI replayed builds of the unpatched dependency (it did on fix(next): keep route-handler framing for bodies Next did not decode #9820)Side-effect audit:
Content-Length(file text preview, CLI OAuth and update checks, desktop updater manifest) use it only as an early size rejection, and each also caps bytes while streaming. Without the header they fall back to the streaming capContent-Encoding; proxy paths already delete itContent-Range; browsers lose the total size/progress for streamed route-handler downloads until large files are served from signed storage URLsType of Change
Testing
turbo run build --dry=json: with staging'sturbo.json, editingpatches/next@16.4.5.patchleaves the@sim/app#buildhash unchanged; with this change the hash changescompressionskipsCache-Control: no-transformresponsessse, workflow streaming, managed-agent run session, mothership chat post, lifecycle start: 186 tests passcheck:auditsrun in CIChecklist
test-auditauthoring gate)