Skip to content

fix(next): align with route-handler framing in 16.4.5 and hash Bun patches into turbo tasks - #9822

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/next-framing-upstream
Nov 9, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/next-framing-upstream

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Side-effect audit:

  • Same-origin readers of Content-Length (file text preview, CLI OAuth and update checks, desktop updater manifest) use it only as an early size rejection, and each also caps bytes while streaming. Without the header they fall back to the streaming cap
  • No route sends a pre-compressed body with Content-Encoding; proxy paths already delete it
  • In-process delivery integration tests bypass Next's sender and are unaffected
  • Downloads still stream and range responses still carry Content-Range; browsers lose the total size/progress for streamed route-handler downloads until large files are served from signed storage URLs

Type of Change

  • Bug fix

Testing

  • turbo run build --dry=json: with staging's turbo.json, editing patches/next@16.4.5.patch leaves the @sim/app#build hash unchanged; with this change the hash changes
  • Confirmed Next's bundled compression skips Cache-Control: no-transform responses
  • SSE-adjacent suites: chat identifier route, copilot chat stream route, sse, workflow streaming, managed-agent run session, mothership chat post, lifecycle start: 186 tests pass
  • Project-files E2E, lint, type-check, and check:audits run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 9, 2026 11:41pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

This PR updates SSE headers and makes patch edits affect Turbo task hashes.

  • SSE responses signal that streams should not be buffered for compression.
  • Patch edits now change every Turborepo task hash.

Reviews (2) · Last reviewed commit: "fix(next): align with route-handler fram..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 force-pushed the fix/next-framing-upstream branch from 0aa71b4 to ea30ad2 Compare November 9, 2026 23:35
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was successfully deployed

1 active deployment
Preview — ea30ad25 Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant