Skip to content

fix(docs): polish code rendering and keyboard navigation - #9827

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/docs-surface-audit
Nov 10, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/docs-surface-audit

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Keep literal punctuation aligned in inline code and code samples.
  • Remove duplicate scrolling stops and inactive tab panels from keyboard navigation while preserving access before hydration.
  • Use the full editor capture in the shared screenshot frame and correct four generated API response examples.

Type of Change

  • Bug fix

Testing

  • Root lint, type-check, block registry check, and all repository audits.
  • Root test suite and existing docs tests.
  • Production docs build, HTTP/MCP acceptance checks, and the full docs corpus checks.
  • JSON request/response sample validation and CLI reference parity.
  • Browser QA across 320–1440px, both themes, image expansion, keyboard navigation, deep links, and unhydrated code scrolling.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (updated the screenshot expectation; passed the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 10, 2026 5:14am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

The PR polishes docs code rendering and keyboard navigation.

  • Code samples keep punctuation clear and keyboard stops focused on useful content.
  • The editor guide shows one broad Markdown capture near the start.
  • Preview endpoints show sample response bodies in the API docs.

The latest changes preserve one keyboard entry per API sample. No actionable new issues or rule violations were found. No previous review threads were supplied. Builds, tests, and browser checks were not run during this review.

Reviews (2) · Last reviewed commit: "fix(docs): give API samples one keyboard..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/docs/components/ui/tabs.tsx Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit de6e53c into staging Nov 10, 2026
84 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/docs-surface-audit branch November 10, 2026 05:18
waleedlatif1 added a commit that referenced this pull request Nov 10, 2026
…iring

Carries #9827's keyboard-reachable code samples and tabs into the docs
components this branch moved to emcn-docs, and records CodeContent's tabIndex
in the EMCN surface snapshot.

This branch was successfully deployed

1 active deployment
Preview — 5dff20a2 Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant