Repository navigation
fix(docker): keep ISR and suffix-list caches writable on a read-only root - #9829
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge with the companion deployment mounts described by the author. SummaryThe PR gives both images writable cache locations for read-only deployments.
Reviews (1) · Last reviewed commit: "fix(docker): keep ISR and suffix-list ca..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.next/server/route-cacheas aVOLUME(created and owned by the app user). Next 16.4 writes every revalidated (ISR) page and route handler response there, so on a read-only root filesystem each revalidation failed withEROFSand the result was never persisted; pages kept serving from the in-memory cacheTLDEXTRACT_CACHE=/tmp/tldextract. tldextract (pulled in by Presidio) caches the Public Suffix List under$HOME/.cache, which is read-only there, so it fell back to its bundled snapshot and warned on every startroute-cache; on a writable root nothing changesType of Change
Testing
route-cache/under the server dist dir, and in tldextract 5.4.0 (cache.py) thatTLDEXTRACT_CACHEoverrides the cache dirChecklist
test-auditauthoring gate)