Repository navigation
fix(firecrawl): complete v2 response and depth compatibility - #9847
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryThis PR updates Firecrawl v2 calls while keeping workflow outputs stable.
Reviews (2) · Last reviewed commit: "fix(firecrawl): preserve index pages wit..." · Reviewed by Greptile |
There was a problem hiding this comment.
1 issue found across 9 files
Confidence score: 3/5
- In
apps/sim/tools/firecrawl/crawl.ts, the depth exclusion also drops/index.htmland/index.phpwithmaxDepth: 1andincludePaths: ['^/docs'], so otherwise allowed pages won't be crawled. Preserve the index-file exception when applying the exclusion.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/tools/firecrawl/crawl.ts">
<violation number="1" location="apps/sim/tools/firecrawl/crawl.ts:166">
P2: Preserve the `/index.html` and `/index.php` exception when applying this depth exclusion; with `maxDepth: 1` and `includePaths: ['^/docs']`, this pattern excludes those otherwise allowed pages.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
14642b3 to
7b3cae1
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Summary
Type of Change
Testing
VITEST_MAX_WORKERS=4 bun run test,bun run lint,bun run type-check,bun run check:audits, and the block-registry check againstorigin/staging.Checklist
test-auditauthoring gate)