feat(network): honor HTTP_PROXY, HTTPS_PROXY and NO_PROXY for guarded requests, AWS SDK clients and OTLP export by waleedlatif1 · Pull Request #9851 · simstudioai/sim

waleedlatif1 · 2026-11-10T20:42:14Z

Summary

Requests through the SSRF guard (SSO OIDC discovery, HTTP block, tools, connectors, webhooks, MCP, model endpoints typed into a block) now honor HTTPS_PROXY / HTTP_PROXY / NO_PROXY with undici's EnvHttpProxyAgent rules. Previously they connected straight to the pinned IP, so proxy-only deployments could not save an OIDC provider
One change in the shared outbound transport covers secureFetchWithPinnedIP, the pinned fetch, and the DNS-guarded fetch. SSRF checks still run: every proxied request and redirect hop is resolved and judged first (honoring the caller's abort signal); the proxy gets the hostname so domain-allowlisting proxies work
AWS SDK clients (S3 storage, Bedrock, SES, Marketplace, AppConfig, CloudWatch metrics, and every AWS integration) and the OTLP exporters bring their own node:http stack, which Bun does not proxy. They now take a shared agent-base agent that picks the proxy per connection and honors NO_PROXY. Integration clients get it through a new awsClientConfig beside awsClientCredentials, so new AWS families inherit it
Nothing changes without a proxy variable: awsRequestHandler returns the caller's options and the SDK keeps its defaults (Bedrock keeps HTTP/2; with a proxy it uses HTTP/1.1, which Converse/ConverseStream support)
https tunnels via CONNECT, http uses absolute-form forwarding; http:// and https:// proxy URLs are supported and anything else fails closed. Proxy credentials come from the URL and never reach the origin. The HTTP block's per-request proxyUrl still wins; gateway-routed orgs are unchanged
SMTP stays direct on purpose: it is not HTTP, and tunnelling it through HTTPS_PROXY would silently reroute existing mail relays
New DOMAIN_VERIFICATION_NAMESERVERS lets the SSO domain TXT lookup use an internal resolver instead of 1.1.1.1/8.8.8.8
Self-hosting networking + env var docs updated, including NO_PROXY guidance for MinIO, VPC endpoints and in-cluster collectors

Type of Change

New feature

Testing

environment-proxy.server.test.ts against real local forward proxies (http and https) and a TLS origin: hostname tunneling + credential isolation for guarded fetches and an S3 client, pinned and DNS-guarded fetches, plain-http absolute-form, NO_PROXY bypass on both stacks, blocked destination and blocked redirect hop never reach the proxy, fail-closed on an unsupported proxy URL, env precedence table, and a probe under the real Bun runtime (guarded fetch + S3)
Red-checked: disabling the transport proxy branch fails 6/7 original cases; removing the SSRF check fails the 2 blocking tests; returning plain options from awsRequestHandler fails both AWS routing tests
Manual Bun probes against a local proxy: S3 and Bedrock reached AWS through the proxy, keep-alive reused the tunnel, and the OTLP exporter tunnelled
lib/internal, lib/selectors, lib/core/network, lib/core/security, providers/bedrock, uploads, email, marketplace, config, monitoring, credentials, SSO suites pass
/simplify and /cleanup passes applied; biome + check:test-patterns; type-check, audits and full suite in CI

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

… outbound requests

vercel · 2026-11-10T20:42:19Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Ignored	Preview	Nov 10, 2026 9:15pm UTC

…ttps proxy

greptile-apps · 2026-11-10T20:45:19Z

Confidence Score: 5/5

[High impact] The latest changes appear safe to merge, with no new actionable findings.

Summary

The PR adds environment-based proxy routing for guarded HTTP requests, AWS clients, and OTLP export.

Guarded HTTP requests can now use the deployment’s proxy settings.
AWS clients can now send requests through a configured HTTP proxy.
OTLP traces, metrics, and logs can now use the deployment’s proxy.
SSO domain checks can use DNS servers chosen for the deployment.

The previous cancellation finding is fixed: both fetch adapters pass the caller’s signal to the destination check. The forbidden environment-cleanup hook is also gone. waleedlatif1 retained the loopback transport tests because they use managed local servers and follow the existing gateway tests; Greptile withdrew its request to move them. No numbered previous comments were supplied.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Guarded HTTP request] --> B{Outbound route}
  B -->|Gateway| C[Organization gateway]
  B -->|Direct| D{Explicit request proxy?}
  D -->|Yes| E[Existing request proxy]
  D -->|No| F{Environment proxy applies?}
  F -->|No| G[Pinned direct connection]
  F -->|Yes| H[Check destination with caller signal]
  H -->|Allowed| I[Send hostname to proxy]
  H -->|Blocked| J[Reject request]
  K[AWS clients and OTLP exporters] --> L[Shared environment-aware agent]
  L --> M[Proxy or direct connection under NO_PROXY]

_{Reviews (4) · Last reviewed commit: "fix(network): record the proxy dependenc..." · Reviewed by Greptile}

waleedlatif1 · 2026-11-10T20:45:44Z

@greptile

waleedlatif1 · 2026-11-10T20:45:45Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-10T20:45:53Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

1 issue found across 9 files

Confidence score: 4/5

environment-proxy.server.ts handles valid wildcard entries differently from EnvHttpProxyAgent: * does not bypass all hosts, and *.example.com also bypasses the apex. Align the matcher’s per-entry wildcard behavior.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/lib/core/network/environment-proxy.server.ts">

<violation number="1" location="apps/sim/lib/core/network/environment-proxy.server.ts:20">
P3: This matcher diverges from `EnvHttpProxyAgent` for valid wildcard entries: `none.invalid,*` does not bypass all hosts, while `*.example.com` incorrectly bypasses the apex. Handle `*` per entry and keep the `*.` form limited to subdomains so guarded and default fetches choose the same route.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

…nvironment proxy

waleedlatif1 · 2026-11-10T21:03:29Z

@greptile

waleedlatif1 · 2026-11-10T21:03:30Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-10T21:03:37Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 40 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

…er the proxy agent as egress infrastructure

waleedlatif1 · 2026-11-10T21:14:50Z

@greptile

waleedlatif1 · 2026-11-10T21:14:51Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-10T21:14:57Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 41 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

feat(network): honor HTTP_PROXY, HTTPS_PROXY and NO_PROXY for guarded…

c6a112f

… outbound requests

fix(network): limit environment proxies to http and https, cover an h…

b313325

…ttps proxy

greptile-apps Bot reviewed Nov 10, 2026

View reviewed changes

Comment thread apps/sim/lib/core/network/transport.server.ts Resolved

Comment thread apps/sim/lib/core/network/environment-proxy.server.test.ts Resolved

greptile-apps Bot reviewed Nov 10, 2026

View reviewed changes

Comment thread apps/sim/lib/core/network/environment-proxy.server.test.ts Resolved

vercel Bot deployed to Preview November 10, 2026 20:53

View deployment

cubic-dev-ai Bot reviewed Nov 10, 2026

View reviewed changes

Comment thread apps/sim/lib/core/network/transport.server.ts Resolved

Comment thread apps/sim/lib/core/network/transport.server.ts Resolved

Comment thread apps/sim/lib/core/network/environment-proxy.server.ts Resolved

feat(network): route AWS SDK clients and OTLP exporters through the e…

f19a3d8

…nvironment proxy

waleedlatif1 requested a review from a team as a code owner November 10, 2026 21:03

waleedlatif1 changed the title ~~feat(network): honor HTTP_PROXY, HTTPS_PROXY and NO_PROXY for guarded outbound requests~~ feat(network): honor HTTP_PROXY, HTTPS_PROXY and NO_PROXY for guarded requests, AWS SDK clients and OTLP export Nov 10, 2026

vercel Bot deployed to Preview November 10, 2026 21:07

View deployment

cubic-dev-ai Bot reviewed Nov 10, 2026

View reviewed changes

Comment thread apps/sim/package.json Resolved

fix(network): record the proxy dependencies under apps/sim and regist…

3cd912f

…er the proxy agent as egress infrastructure

cubic-dev-ai Bot reviewed Nov 10, 2026

View reviewed changes

waleedlatif1 merged commit 8718b9c into staging Nov 10, 2026
91 checks passed

waleedlatif1 deleted the feat/outbound-env-proxy branch November 10, 2026 21:34

waleedlatif1 mentioned this pull request Nov 11, 2026

v0.9.53: saved credentials with keyless AWS and Databricks OIDC, read-only API keys, workspace members endpoint, trigger health and pinned versions, proxy support, search source permissions #9871

Merged

Conversation

waleedlatif1 commented Nov 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Nov 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Nov 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 10, 2026

Uh oh!

waleedlatif1 commented Nov 10, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 10, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 10, 2026

Uh oh!

waleedlatif1 commented Nov 10, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 10, 2026

Uh oh!

waleedlatif1 commented Nov 10, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Nov 10, 2026 •

edited

Loading

vercel Bot commented Nov 10, 2026 •

edited

Loading

greptile-apps Bot commented Nov 10, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading