feat(api): workflow trigger health and enablement through the v2 API by waleedlatif1 · Pull Request #9853 · simstudioai/sim

waleedlatif1 · 2026-11-10T21:15:07Z

Summary

Adds GET /api/v2/workflows/{workflowId}/triggers: every trigger the live deployment serves (schedules, polling, internal event, and push webhook triggers) with kind, enabled, status, failure count, last failure, and next/last run plus cron for schedules
Adds PATCH /api/v2/workflows/{workflowId}/triggers/{blockId} with { enabled }: enabling resets failure counters, re-arms nextRunAt, and clears polling backoff; disabling stops Sim accepting the trigger without tearing down the provider registration. A disable lasts until the next deploy, the same way a redeploy already clears an auto-disabled trigger
Liveness matches delivery exactly: v2 schedules use the dispatcher's active-version test, webhooks the routing/poller predicate. Writes are conditional updates that can never revive a retired, archived, or older-version row, and a block with several live webhook rows switches them together
Moves the internal schedule reactivate/disable and webhook enable routes onto the same use case. Statuses, messages, and response bodies are unchanged, except cross-tenant callers now get a concealed 404, a non-live row is a 404 instead of being toggled, and webhook toggles now write a webhook.updated audit entry
Fixes an auto-disabled webhook silently disappearing from /deployment's view of the world (it now shows up in /triggers as disabled), and makes polling auto-disable a single conditional update so an enable can't be switched straight back off
triggers.webhook permission-group gating on enable is preserved; CLI workflows triggers list|update; regenerated OpenAPI, CLI, MCP operations, and route table

Type of Change

New feature

Testing

apps/sim/lib/workflows/application/triggers.integration.ts (14 passing) against PostgreSQL: live-row listing, write-time liveness refusal, counter/backoff reset, scalar provider configs, versionless schedules, multi-row blocks, cron validation, lock, role and tenant boundaries, capability gate, no-op audit, poll auto-disable threshold; reverting the liveness predicate, capability gate, no-op detection, counter reset, dispatcher predicate, and config guard each turns its test red
operations.test.ts, list-pagination.test.ts, copilot-route-inventory.test.ts
tsc on apps/sim; check:openapi, cli-api, cli-docs, mcp-operations, v2-route-table, route-verbs, permission-group-enforcement, capability-subject, principal-kind-parity, api-validation:strict, source-conventions, test-patterns, boundaries; biome

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

GET /api/v2/workflows/{workflowId}/triggers lists every schedule, polling, internal-event, and webhook trigger the live deployment serves, disabled ones included, with failure counts. PATCH .../triggers/{blockId} enables or disables one without redeploying: enabling resets the failure counters, re-arms a schedule's next run, and clears polling backoff; a schedule with no future run is a 409. Liveness is the active deployment version plus an active or legacy registration, enforced inside one conditional UPDATE, so a candidate, retired, or older-version row is never revived. Adds workflows.triggers.read / workflows.triggers.set_enabled, the WEBHOOK_UPDATED audit action, and the CLI commands `workflows triggers list|update`.

… the trigger use case PUT /api/schedules/[id] and PATCH /api/webhooks/[id] now call setWorkflowTriggerEnabled, which owns authorization, the workflow lock, the triggers.webhook gate on re-enabling, and audit. Both keep their response shapes. The id must name the live deployment's row, so these routes can no longer revive a candidate, retired, or older-version registration, and the webhook route no longer writes an arbitrary failedCount (failedCount: 0 is still accepted and ignored). Webhook re-enable and disable are now audited. Removes the mock-based route tests the integration suite replaces.

…ock, keep legacy route behavior Live rows now use the delivery and editor deployment test (active version, or versionless deploy with no version id) and no longer filter on registration status, so the editor never shows a row the legacy toggle rejects. A block target switches all of its live rows in one transaction; a row id switches only that row. Disabling a completed schedule moves it to disabled again, a cron with no future run is a 400 with the legacy message, and same-workspace role denials keep their legacy 403 bodies.

… atomic poll auto-disable The v2 list and block target read schedules with the dispatcher's own predicate, so a versionless schedule that never fires is not reported; the legacy row-id route keeps it for the editor. Enabling clears poll backoff only on polling rows with an object config. An unknown schedule status reads as active instead of failing the list. markWebhookFailed increments and auto-disables in one statement, so a concurrent enable is never switched off by a decision made on the old count. Documents that a disable lasts until the next deploy or activation, and that workspace keys are not governed by the webhook capability.

vercel · 2026-11-10T21:15:09Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Nov 10, 2026 9:40pm UTC

greptile-apps · 2026-11-10T21:20:10Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new blocking issues remain.

Summary

Adds v2 endpoints and CLI commands to inspect trigger health and enable or disable triggers without redeploying.

The v2 API lists and switches triggers on live workflow deployments.
Schedule and webhook editor controls use shared trigger enablement rules.
Polling failure counts and auto-disable state change together.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[V2 trigger PATCH] --> C[Shared trigger use case]
  B[Internal schedule or webhook route] --> C
  C --> D[Check workspace access and workflow lock]
  D --> E[Find eligible trigger rows]
  E --> F[Check permission when enabling webhooks]
  F --> G[Update rows in one transaction]
  G --> H{Every targeted row updated?}
  H -->|Yes| I[Return state and record changes]
  H -->|No| J[Roll back and reread]
  J --> K[Return no-op or conflict]

_{Reviews (2) · Last reviewed commit: "fix(triggers): v2 reports only triggers ..." · Reviewed by Greptile}

cubic-dev-ai

Review completed against the latest diff

_{Turn on auto-fix | Re-trigger cubic}

…TCH, switch all or nothing The v2 list and block target require the active version of a deployed workflow for both tables, since webhook processing refuses a versionless or undeployed row; the legacy row-id routes keep the editor's view. PATCH /api/webhooks/[id] admits a workflow run's executor delegation again, and setTriggerEnabled admits the executor service. A multi-row switch rolls back entirely when any row was retired or switched concurrently, so a conflict commits nothing. Adds the two new CLI fences to the docs content baseline.

waleedlatif1 · 2026-11-10T21:29:08Z

@greptile

waleedlatif1 · 2026-11-10T21:29:09Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-10T21:29:17Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

…rigger-health

cubic-dev-ai

All reported issues were addressed across 34 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 added 5 commits November 10, 2026 12:45

test(workflows): integration suite for trigger health and enablement

685fea3

test(cli): classify workflow trigger enablement as non-destructive

caf5c95

vercel Bot temporarily deployed to Preview November 10, 2026 21:16 Inactive

greptile-apps Bot reviewed Nov 10, 2026

View reviewed changes

Comment thread apps/sim/lib/workflows/triggers/health.ts Resolved

Comment thread apps/sim/app/api/webhooks/[id]/route.ts Resolved

cubic-dev-ai Bot reviewed Nov 10, 2026

View reviewed changes

Comment thread apps/sim/lib/workflows/application/triggers.ts Resolved

Comment thread apps/sim/app/api/webhooks/[id]/route.ts Resolved

Merge remote-tracking branch 'origin/staging' into feat/v2-workflow-t…

b682487

…rigger-health

cubic-dev-ai Bot reviewed Nov 10, 2026

View reviewed changes

Comment thread apps/sim/lib/workflows/application/triggers.ts Resolved

vercel Bot deployed to Preview November 10, 2026 21:33

View deployment

fix(triggers): conceal a workflow-less trigger row as not found

ddda582

vercel Bot temporarily deployed to Preview November 10, 2026 21:37 Inactive

waleedlatif1 merged commit 4711852 into staging Nov 10, 2026
81 checks passed

waleedlatif1 deleted the feat/v2-workflow-trigger-health branch November 10, 2026 21:54

waleedlatif1 mentioned this pull request Nov 11, 2026

v0.9.53: saved credentials with keyless AWS and Databricks OIDC, read-only API keys, workspace members endpoint, trigger health and pinned versions, proxy support, search source permissions #9871

Merged

Navigation Menu

Repository navigation

feat(api): workflow trigger health and enablement through the v2 API - #9853

feat(api): workflow trigger health and enablement through the v2 API#9853
waleedlatif1 merged 9 commits into
stagingfrom
feat/v2-workflow-trigger-health

waleedlatif1 commented Nov 10, 2026

Uh oh!

vercel Bot commented Nov 10, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Nov 10, 2026 •

edited

Loading

Diagram

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 10, 2026

Uh oh!

waleedlatif1 commented Nov 10, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

waleedlatif1 commented Nov 10, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Nov 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Nov 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 10, 2026

Uh oh!

waleedlatif1 commented Nov 10, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Nov 10, 2026 •

edited

Loading

greptile-apps Bot commented Nov 10, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading