Skip to content

fix(release): reuse only full-access delegation keys and treat a blank crawl depth as unset - #9857

Merged
waleedlatif1 merged 5 commits into
stagingfrom
fix/release-audit-cleanup
Nov 11, 2026
Merged

waleedlatif1 merged 5 commits into
stagingfrom
fix/release-audit-cleanup

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Type of Change

  • Bug fix

Testing

  • lib/mothership/chat/delegation.test.ts passing; biome on the changed file

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 11, 2026 12:05am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

The PR limits delegation-key reuse to full-access personal keys and explicitly gives new keys write access.

  • Mothership gives its embedded CLI only write-access delegation keys.
  • Blank Firecrawl crawl depth leaves depth filters unset.

Reviews (2) · Last reviewed commit: "test(release): prove delegation refuses ..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/firecrawl/crawl.ts Resolved
Comment thread apps/sim/tools/firecrawl/crawl.ts Resolved
Comment thread apps/sim/tools/firecrawl/crawl.ts Resolved
@waleedlatif1 waleedlatif1 changed the title fix(release): measure Firecrawl crawl depth from the start URL and reuse only full-access delegation keys fix(mothership): reuse only full-access delegation keys Nov 10, 2026
@waleedlatif1 waleedlatif1 changed the title fix(mothership): reuse only full-access delegation keys fix(release): reuse only full-access delegation keys and treat a blank crawl depth as unset Nov 10, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — 18585865 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant