Skip to content

fix(release): run pinned async versions on their own variables, map CLI key-creation errors, show GitLab tokens as the current block - #9862

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/release-followups-1110
Nov 11, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/release-followups-1110

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • An async run pinned to a deployment version that predates variable snapshots runs with that version's own (empty) variables, matching a sync run of it, instead of the editor's current variables. Only explicit run.version async runs (new in feat(api): run a pinned deployment version and expose paused run points in v2 #9854, not yet released) set a pin; unpinned async, schedule and webhook runs keep resolveDeployedRunVariables unchanged
  • CLI login poll answers a rejected key creation with the shared status mapping (400 for validation, not 500)
  • GitLab personal-token credentials render as the current GitLab block instead of the hidden legacy one
  • PII Dockerfile: correct the tldextract cache comment (the /tmp volume is per task)

Scoped to what no other release-audit PR covers: crawl depth is on staging via #9860; workflow access middleware, route policies and CONTRIBUTING are in #9858. Firecrawl search sources handling is left out pending a product decision (the block never forwards sources today).

Type of Change

  • Bug fix

Testing

  • lib/integrations/credential-display.test.ts passes
  • biome on changed files; type-check, audits and full suites in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 10, 2026 11:56pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/firecrawl/search.ts Resolved
@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The current diff appears safe to merge.

Summary

This diff makes three small behavior fixes and clarifies a Dockerfile comment:

  • Pinned async runs use the variables from their selected deployment.
  • CLI login polls report key-creation errors with the shared status rules.
  • GitLab personal-token credentials use the current block type.
  • The PII Dockerfile explains that its cache is task-local.

No new actionable issues were found. Firecrawl changes described in the PR are not part of the current diff.

Reviews (3) · Last reviewed commit: "fix(release): run pinned async versions ..." · Reviewed by Greptile

Comment thread apps/sim/tools/firecrawl/search.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 18 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1 waleedlatif1 changed the title fix(release): keep Firecrawl news/image results, refuse unreachable crawl depth, run pinned async versions on their own variables fix(release): keep Firecrawl news/image search results, run pinned async versions on their own variables Nov 10, 2026
@waleedlatif1
waleedlatif1 force-pushed the fix/release-followups-1110 branch from af4d72d to 33f650f Compare November 10, 2026 23:47
…LI key-creation errors, show GitLab tokens as the current block
@waleedlatif1
waleedlatif1 force-pushed the fix/release-followups-1110 branch from 33f650f to 3ba0ef7 Compare November 10, 2026 23:47
@waleedlatif1 waleedlatif1 changed the title fix(release): keep Firecrawl news/image search results, run pinned async versions on their own variables fix(release): run pinned async versions on their own variables, map CLI key-creation errors, show GitLab tokens as the current block Nov 10, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was successfully deployed

1 active deployment
Preview — 3ba0ef70 Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant