Skip to content

docs(release): correct the Discord allowlist note, Mistral image naming, and the NO_PROXY reference - #9874

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/sim-ba-final-accuracy-nits
Nov 11, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/sim-ba-final-accuracy-nits

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Accuracy fixes from a final read-only audit of the Mistral Parser image extraction and the saved-credential contract on staging. No behavior change.

  • saved-credential-contract.ts: the Discord allowlist comment said serverId is a guild id in the API path; the operation never sends it and posts only to the channel's discord.com endpoint
  • Mistral Parser images output description now says the file extension comes from the detected image type (img-0.jpeg is stored as page-0-img-0.jpg); regenerated tool outputs and the integration docs
  • operations.test.ts: renamed a png fixture that holds JPEG bytes
  • networking.mdx: the SSRF guard sentence now points at the explicit NO_PROXY rules instead of saying it matches "the way curl does", which overstated it (curl does not document *.example.com)

Type of Change

  • Documentation

Testing

  • bunx vitest run lib/internal/mistral scripts/saved-credential-contract.test.ts — 70 passed
  • check-block-registry.ts origin/staging, check:docs, check:comment-hygiene, check:site-urls; regenerated tool metadata and docs
  • lint:check + type-check via the pre-push hook

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 11, 2026 2:50am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Corrects the Discord comment, clarifies Mistral image filenames, and replaces the curl comparison with Sim’s explicit NO_PROXY rules.

  • Mistral image descriptions explain how each stored file gets its extension.
  • The networking guide describes Sim’s NO_PROXY rules without comparing them to curl.
  • The Discord contract note identifies the channel endpoint as the destination.

Reviews (2) · Last reviewed commit: "docs(networking): state the NO_PROXY rul..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was successfully deployed

1 active deployment
Preview — 12ad27cc Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant