[piercifani]

Stack 19/21 · base: jni/18-async-closures · previous: #22 · next: #24 (jni/20-nullability-annotations)

Problem

With payloadlessEnumsAsJavaEnums (#17), Java enum constants were uppercased, like the Discriminator of enum classes: OrderStatus.FILLED. Swift code spells the case .filled, and so does Kotlin code written against the Swift API or translated from it.

Changes

• Names: constants keep the Swift case name, OrderStatus.filled, matching the case factory method filled() they sit next to.
• Keywords: a case named after a Java keyword, such as `default`, gets a trailing _, as methods already do.
• Docs: payloadlessEnumsAsJavaEnums' documentation says how constants are named.

Discriminator, on enum classes, keeps its uppercase names.

Kotlin in this PR

JavaEnumsTest.kt uses the Swift names:

val label = when (Orders.fill(OrderStatus.pending)) {
    OrderStatus.pending -> "pending"
    OrderStatus.filled -> "filled"
    OrderStatus.cancelled -> "cancelled"
}

Why Skip needs it

Skip keeps Swift's case names in the Kotlin enum classes it generates, and the app's Kotlin code refers to them by those names.

Testing

• Kotlin sample: JavaEnumsTest passes with the Swift names, as does the full Kotlin sample (47 tests).
• JNIJavaEnumTests: constants named like the cases; a new test for `default` → default_.
• Full swift test --disable-experimental-prebuilts --disable-sandbox (690 tests) and ./gradlew :Samples:SwiftJavaExtractJNISampleApp:test (302 tests) pass, measured with the next PR applied.
• swift run generate-config-docs --check; swift format format leaves changed files unchanged; git diff --check.

🤖 Generated with Claude Code