Repository navigation
fix(types): add missing file fields to ThreadBroadcastMessageEvent - #2763
Conversation
🦋 Changeset detectedLatest commit: d9642d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2763 +/- ##
==========================================
- Coverage 89.45% 89.44% -0.01%
==========================================
Files 65 65
Lines 10525 10525
Branches 478 478
==========================================
- Hits 9415 9414 -1
- Misses 1079 1080 +1
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
codecov failing by .01% 😬 can we increase the threshold for cases like this? cc. @zimeg @WilliamBergamin |
These tests use the |
Summary
Fixes #2762.
ThreadBroadcastMessageEventwas missing fields that Slack sends when a thread reply with an attached file is also sent to the channel. This adds them as optional fields, matchingFileShareMessageEvent:files?: File[]upload?: booleandisplay_as_bot?: booleanparent_user_id?: stringI reproduced this with a Bolt app subscribed to
message.channels:parent_user_id. That's why every field is optional.x_files(present onFileShareMessageEvent) was not sent in either case, so it isn't added here.This also adds a tsd test in
packages/types/test/events/message.test-d.tsand a patch changeset for@slack/types.Requirements