fix: properly check error return value in upgrade command

Author: kkemple

cmd/upgrade/upgrade.go

@@ -32,7 +32,7 @@ const changelogURL = "https://docs.slack.dev/changelog"
 
 func NewCommand(clients *shared.ClientFactory) *cobra.Command {
 	var autoApprove bool
-	
+
 	cmd := &cobra.Command{
 		Use:     "upgrade",
 		Aliases: []string{"update"},
@@ -52,9 +52,9 @@ func NewCommand(clients *shared.ClientFactory) *cobra.Command {
 			return checkForUpdatesFunc(clients, cmd, autoApprove)
 		},
 	}
-	
+
 	cmd.Flags().BoolVar(&autoApprove, "auto-approve", false, "automatically approve and install updates without prompting")
-	
+
 	return cmd
 }
 
@@ -79,7 +79,9 @@ func checkForUpdates(clients *shared.ClientFactory, cmd *cobra.Command, autoAppr
 	if updateNotification.HasUpdate() {
 		if autoApprove {
 			// Automatically install updates without prompting when auto-approve flag is set
-			updateNotification.InstallUpdatesWithoutPrompt(cmd)
+			if err := updateNotification.InstallUpdatesWithoutPrompt(cmd); err != nil {
+				return err
+			}
 			return nil
 		}
 		return nil

cmd/upgrade/upgrade_test.go

@@ -61,11 +61,11 @@ func TestUpgradeCommand(t *testing.T) {
 	cmd = NewCommand(clients)
 	testutil.MockCmdIO(clients.IO, cmd)
 	cmd.SetArgs([]string{"--auto-approve"})
-	
+
 	updatePkgMock = new(UpdatePkgMock)
 	checkForUpdatesFunc = updatePkgMock.CheckForUpdates
 	updatePkgMock.On("CheckForUpdates", mock.Anything, mock.Anything, true).Return(nil)
-	
+
 	err = cmd.ExecuteContext(ctx)
 	if err != nil {
 		assert.Fail(t, "cmd.Upgrade with auto-approve had unexpected error")

internal/update/cli.go

@@ -93,15 +93,15 @@ func (c *CLIDependency) PrintUpdateNotification(cmd *cobra.Command) (bool, error
 			"\n   To manually update, visit the download page:\n   %s\n\n",
 			style.CommandText("https://tools.slack.dev/slack-cli"),
 		)
-		
+
 		// Check for auto-approve from upgrade command
 		if cmd.Name() == "upgrade" && cmd.Flags().Changed("auto-approve") {
 			autoApprove, _ := cmd.Flags().GetBool("auto-approve")
 			if autoApprove {
-				return true, nil 
+				return true, nil
 			}
 		}
-		
+
 		selfUpdatePrompt := fmt.Sprintf("%sDo you want to auto-update to the latest version now?", style.Emoji("rocket"))
 		return c.clients.IO.ConfirmPrompt(ctx, selfUpdatePrompt, false)
 	}

internal/update/sdk.go

@@ -326,7 +326,7 @@ func (c *SDKDependency) PrintUpdateNotification(cmd *cobra.Command) (bool, error
 				return true, nil
 			}
 		}
-		
+
 		autoUpdatePrompt := fmt.Sprintf("%sDo you want to auto-update to the latest versions now?", style.Emoji("rocket"))
 		return c.clients.IO.ConfirmPrompt(ctx, autoUpdatePrompt, false)
 	}

internal/update/update.go

@@ -270,7 +270,7 @@ func (u *UpdateNotification) InstallUpdatesWithoutPrompt(cmd *cobra.Command) err
 			if err != nil {
 				return err
 			}
-			
+
 			// Install the update without prompting
 			cmd.Printf("%s Installing update automatically...\n", style.Styler().Green("✓").String())
 			if err := dependency.InstallUpdate(ctx); err != nil {