Skip to content

feat(#622): 错峰时段串解析失败不再静默——启动告警 + 面板提示 - #629

Open
modusensus wants to merge 1 commit into
mainfrom
feat/622-peak-hours-observability
Open

modusensus wants to merge 1 commit into
mainfrom
feat/622-peak-hours-observability

Conversation

@modusensus

Copy link
Copy Markdown
Member

做什么

#622 的可观测性补丁。parsePeakSpec 的失败语义(整串视为未配置)不动——排程是省钱手段,绝不因为写错格式把蒸馏/巩固停掉;补的是可见性:配置写错的唯一症状从「功能悄悄没生效」(#424 的排查只能靠『高峰期还在巩固』倒推)变成启动日志一条 warn + 面板输入行下一条红色提示。

实现

验证

  • npm test:3159 / 3158 通过 / 0 失败 / 1 跳过;check-sync 通过(118 文件)。
  • 新增 test/peak-hours-observability.test.js 3 条(helper 只报「非空且解析失败」+ 全角现状断言 + 接线锁:告警读装配后的 cfg、不改写 cfg、排在 sessionGate 之前);test/api.test.js +1(GET/PUT 答复字段与 helper 同源,合法/空串不报);test/client.test.js +1(提示行走服务端字段、反拷贝锁匹配调用形态、i18n 双语键成对)。
  • docs:CONFIGURATION.md 两个键行补可见性说明(全键闸通过)+ CHANGELOG。
  • euthyna 审计已过:audit + history --pickaxe 两次测量,2 条删除行事实逐条阶段 C 裁定 0 TRUE POSITIVE / 2 FALSE POSITIVE(文档行就地扩展、pendingRestart 逐字保留);euthyna gate 2/2 通过(exit 0)。报告在车道本地不入库。

Closes #622

Copilot AI lite review requested due to automatic review settings November 9, 2026 21:20
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 514d238 and 45a1325.

Files selected for processing: 12

  • dsh-mneme/CHANGELOG.md
  • dsh-mneme/docs/CONFIGURATION.md
  • dsh-mneme/lib/api.js
  • dsh-mneme/lib/client.js
  • dsh-mneme/lib/index.js
  • dsh-mneme/lib/peak-hours.js
  • dsh-mneme/src/api.js
  • dsh-mneme/src/index.js
  • dsh-mneme/src/peak-hours.js
  • dsh-mneme/test/api.test.js
  • dsh-mneme/test/client.test.js
  • dsh-mneme/test/peak-hours-observability.test.js
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.37931% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
dsh-mneme/src/index.js 68.75% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[observability] peak-hours 时段串解析失败仍是静默的:非空配置解析成 null 应有显式提示

2 participants