Skip to content

docs(#532): 选择性遗忘与事实更正的根因定案——失效关系缺口 + memory_forget 行粒度警示 - #633

Open
modusensus wants to merge 1 commit into
mainfrom
feat/532-supersede-before-dream
Open

modusensus wants to merge 1 commit into
mainfrom
feat/532-supersede-before-dream

Conversation

@modusensus

Copy link
Copy Markdown
Member

做什么

#532 的三个确认请求逐条给了源码级回答(docs/FORGET.md),并落地两件零争议的改动。现象不是某一行写错,而是三段契约的接缝:

  1. 更正落成新行:蒸馏按内容起标题 → (type,title,scope) 三元组不命中 → 同一事实两个版本同时活跃;会清理并存的 dream 冲突裁决是阈值门控的(选择性遗忘后,明确保留的更正事实答回旧值(Mneme 0.9.4,正常DSH GUI) #532 现场 13 条、0 次 dream)。summarizeDedupeMode(默认 off)也帮不上——它只在同会话时间窗内并,跨会话更正够不着。
  2. memory_forget 是行粒度的(接口契约:按 ID 翻 forgotten 标志、原文留存可恢复)——更正把两个新值合流在一行时,忘掉「颜色」的操作把新的整理时间一起带出可见面。
  3. 旧值行成了唯一幸存载体:旧行与新行之间没有任何持久链接,任何一方的隐藏都不波及另一方。「更正的失效关系在 dream 第一次运行之前不存在」是插件层面的真实缺口,不是配置遗漏(Q2/Q3 的回答)。

三问的回答(docs/FORGET.md §2)

本 PR 落地的两件(修复方向的 A–D 取舍表在 §3,涉及 LLM 判断进哪条路径,按 R2/R3 纪律待拍板,不擅自实现)

  • memory_forget 工具描述补行粒度警示:抑制的是一行——合流事实连带退出;请求只针对一个事实时先 memory_get、memory_update 拆分或说清连带。选择性遗忘后,明确保留的更正事实答回旧值(Mneme 0.9.4,正常DSH GUI) #532 对话 5 模型误用的直接对策。
  • 零 LLM 的最小合成轨迹(议主点名要的最小复现):test/forget-corrections.test.js 四步断言(更正落新行 → 遗忘新行 → 旧行原样幸存),存储层等价物,注释写明机制修复落地时第 ⑤ 条翻转的条件——防止被当成「永远该绿」的现状锁。

验证

  • npm test:3156 / 3155 通过 / 0 失败 / 1 跳过;check-sync 通过。
  • euthyna 审计已过:audit + history --pickaxe,1 条删除行事实裁定 0 TRUE POSITIVE / 1 FALSE POSITIVE(描述续行逐字保留、纯追加);euthyna gate 1/1 通过(exit 0)。报告在车道本地不入库。

Related #532(不 close:机制修复待拍板后另账)

Copilot AI lite review requested due to automatic review settings November 9, 2026 21:46
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 514d238 and 7e210fc.

Files selected for processing: 6

  • dsh-mneme/CHANGELOG.md
  • dsh-mneme/README.md
  • dsh-mneme/docs/FORGET.md
  • dsh-mneme/lib/tools.js
  • dsh-mneme/src/tools.js
  • dsh-mneme/test/forget-corrections.test.js
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants