Skip to content

Lint Roller 4: core/services/gateway - #23496

Open
kalverra wants to merge 1 commit into
DX-5066/03-core-cmdfrom
DX-5066/04-core-gateway
Open

Lint Roller 4: core/services/gateway#23496
kalverra wants to merge 1 commit into
DX-5066/03-core-cmdfrom
DX-5066/04-core-gateway

Conversation

@kalverra

Copy link
Copy Markdown
Collaborator

Issues Fixed

Linter Issues Fixed
testifylint 64
revive 28
prealloc 14
gocritic 7
bodyclose 2
staticcheck 1
Total 116

Packages Covered

  • core/services/gateway/...

Stack created with GitHub Stacks CLIGive Feedback 💬

@kalverra
kalverra requested review from a team as code owners August 23, 2026 18:15
@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
* 48 @smartcontractkit/foundations, @smartcontractkit/core
/core/capabilities/ 6 @smartcontractkit/keystone, @smartcontractkit/capabilities-team
/core/services/workflows/ 2 @smartcontractkit/keystone
/core/services/gateway/handlers/confidentialrelay/ 2 @smartcontractkit/privacy

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Aug 23, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
FuzzParseETHABIArgsString/seed#0 A goroutine attempted to log after the test had completed, causing a panic due to a failed connection dial. Logs ↗︎
FuzzParseETHABIArgsString A goroutine logged an error after the test completed due to a failed connection attempt to a test bridge, indicating a connection setup issue durin... Logs ↗︎
TestConnectionManager_ReadyForTrafficRequiresEveryShard The test failed because a node address was unexpected, indicating a mismatch or misconfiguration in the network setup. Logs ↗︎

View Full Report ↗︎Docs

@kalverra
kalverra force-pushed the DX-5066/04-core-gateway branch from 1e2e669 to 01fd2b8 Compare August 24, 2026 18:24
@kalverra
kalverra force-pushed the DX-5066/04-core-gateway branch 2 times, most recently from 56a37a0 to fbd0417 Compare August 24, 2026 21:12
@kalverra
kalverra requested review from a team as code owners August 25, 2026 16:30
@kalverra
kalverra force-pushed the DX-5066/04-core-gateway branch from fbd0417 to d619927 Compare August 25, 2026 17:44
@kalverra
kalverra force-pushed the DX-5066/04-core-gateway branch from d619927 to 4148b50 Compare August 25, 2026 17:53
@kalverra
kalverra force-pushed the DX-5066/04-core-gateway branch from 4148b50 to f9f5f2a Compare August 26, 2026 19:35
@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant