Skip to content

Lint Roller 5: core/services (job, keystore, ocr2keeper) - #23497

Open
kalverra wants to merge 3 commits into
DX-5066/04-core-gatewayfrom
DX-5066/05-core-job-keystore-ocr2
Open

Lint Roller 5: core/services (job, keystore, ocr2keeper)#23497
kalverra wants to merge 3 commits into
DX-5066/04-core-gatewayfrom
DX-5066/05-core-job-keystore-ocr2

Conversation

@kalverra

Copy link
Copy Markdown
Collaborator

Issues Fixed

Linter Issues Fixed
testifylint 82
prealloc 47
revive 31
recvcheck 12
gocritic 11
staticcheck 3
gosec 2
Total 188

Packages Covered

  • core/services/job
  • core/services/keystore
  • core/services/ocr2/plugins/ocr2keeper

Stack created with GitHub Stacks CLIGive Feedback 💬

@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Aug 23, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestConnectionManager_ReadyForTrafficRequiresEveryShard The test failed because a node address was unexpected, indicating a mismatch or misconfiguration in the network setup. Logs ↗︎

View Full Report ↗︎Docs

pavel-raykov
pavel-raykov previously approved these changes Aug 24, 2026
@kalverra
kalverra force-pushed the DX-5066/05-core-job-keystore-ocr2 branch from fd5fc37 to eeedef1 Compare August 24, 2026 18:24
@kalverra
kalverra requested review from a team as code owners August 24, 2026 21:07
@kalverra
kalverra force-pushed the DX-5066/05-core-job-keystore-ocr2 branch from eeedef1 to 194010b Compare August 24, 2026 21:07
@kalverra
kalverra force-pushed the DX-5066/05-core-job-keystore-ocr2 branch from 194010b to b882622 Compare August 24, 2026 21:12
@kalverra
kalverra force-pushed the DX-5066/05-core-job-keystore-ocr2 branch 2 times, most recently from 403e3ca to 1b5245f Compare August 25, 2026 17:53
@kalverra
kalverra force-pushed the DX-5066/05-core-job-keystore-ocr2 branch from 1b5245f to 8bf32b5 Compare August 26, 2026 19:36
@kalverra
kalverra force-pushed the DX-5066/05-core-job-keystore-ocr2 branch from 8bf32b5 to 66760e0 Compare August 27, 2026 17:56
@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants