Lint Roller 7: core/services - #23499
Open
kalverra wants to merge 1 commit into
Open
Conversation
product-security-plaid-production
Bot
requested review from
Fletch153,
patrickhuie19,
skudasov and
timothyF95
August 23, 2026 18:15
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
product-security-plaid-production
Bot
requested review from
4of9,
engnke,
fouadkada,
kirqz23,
pkcll,
skippaDaBitFlippa and
thomaska
August 23, 2026 18:15
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
|
|
jmank88
reviewed
Aug 24, 2026
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/grpc/status" | ||
|
|
||
| common "github.com/smartcontractkit/chainlink-common/pkg/logger" |
Contributor
There was a problem hiding this comment.
Suggested change
| common "github.com/smartcontractkit/chainlink-common/pkg/logger" | |
| "github.com/smartcontractkit/chainlink-common/pkg/logger" |
jmank88
reviewed
Aug 24, 2026
| "time" | ||
|
|
||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/pkg/errors" |
Contributor
There was a problem hiding this comment.
We actually want to block this module entirely, but haven't due to legacy uses
Suggested change
| "github.com/pkg/errors" |
jmank88
reviewed
Aug 24, 2026
Comment on lines
76
to
+78
| return nil, fmt.Errorf( | ||
| "getting chain ID %s: %w", cid, err) | ||
| "getting chain ID %s: %w", cid, err, | ||
| ) |
Contributor
There was a problem hiding this comment.
IMHO this looks worse, but regardless, why wrap at all?
return nil, fmt.Errorf("getting chain ID %s: %w", cid, err)
jmank88
reviewed
Aug 24, 2026
|
|
||
| "github.com/pkg/errors" | ||
|
|
||
| common "github.com/smartcontractkit/chainlink-common/pkg/logger" |
Contributor
There was a problem hiding this comment.
Suggested change
| common "github.com/smartcontractkit/chainlink-common/pkg/logger" | |
| "github.com/smartcontractkit/chainlink-common/pkg/logger" |
jmank88
reviewed
Aug 24, 2026
| legacyChains legacyevm.LegacyChainContainer, | ||
| lggr logger.Logger, | ||
| mailMon *mailbox.Monitor) *Delegate { | ||
| lggr logger.SugaredLogger, |
Contributor
There was a problem hiding this comment.
This doesn't make sense paired with a call to logger.Sugared below. But why do we need either of them? Are the methods used?
kalverra
force-pushed
the
DX-5066/07-core-services
branch
from
August 24, 2026 18:24
ffd11ac to
a281188
Compare
kalverra
force-pushed
the
DX-5066/07-core-services
branch
2 times, most recently
from
August 24, 2026 21:12
4569e42 to
573b199
Compare
kalverra
requested review from
AmrMohamedRezk,
agusaldasoro,
carte7000,
makramkd,
matYang,
ogtownsend and
tt-cll
August 25, 2026 17:45
kalverra
force-pushed
the
DX-5066/07-core-services
branch
from
August 25, 2026 17:45
573b199 to
c9951f5
Compare
kalverra
force-pushed
the
DX-5066/07-core-services
branch
from
August 25, 2026 17:53
c9951f5 to
0762e18
Compare
kalverra
force-pushed
the
DX-5066/07-core-services
branch
from
August 26, 2026 19:36
0762e18 to
39dee3f
Compare
kalverra
force-pushed
the
DX-5066/07-core-services
branch
from
August 27, 2026 17:56
39dee3f to
d82f0e3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
testifylintrevivepreallocgocriticstaticcheckbodycloserecvcheckerrnamePackages Covered
core/services/...Stack created with GitHub Stacks CLI • Give Feedback 💬