Skip to content

Lint Roller 8: core (utils, web) - #23500

Open
kalverra wants to merge 2 commits into
DX-5066/07-core-servicesfrom
DX-5066/08-core-utils-web
Open

Lint Roller 8: core (utils, web)#23500
kalverra wants to merge 2 commits into
DX-5066/07-core-servicesfrom
DX-5066/08-core-utils-web

Conversation

@kalverra

Copy link
Copy Markdown
Collaborator

Issues Fixed

Linter Issues Fixed
testifylint 158
revive 61
prealloc 37
gocritic 19
bodyclose 11
staticcheck 9
Total 295

Packages Covered

  • core/utils
  • core/web

Stack created with GitHub Stacks CLIGive Feedback 💬

@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Aug 23, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestConnectionManager_ReadyForTrafficRequiresEveryShard The test failed due to an unexpected node address error and network connection issues during WebSocket communication. Logs ↗︎

View Full Report ↗︎Docs

@kalverra
kalverra force-pushed the DX-5066/08-core-utils-web branch from 2a26d7d to c4cc3fc Compare August 24, 2026 21:12
@kalverra
kalverra force-pushed the DX-5066/08-core-utils-web branch 2 times, most recently from a4dfe9c to aaaa55d Compare August 25, 2026 17:53
@kalverra
kalverra force-pushed the DX-5066/08-core-utils-web branch from aaaa55d to 9e9b1dc Compare August 26, 2026 19:36
@kalverra
kalverra force-pushed the DX-5066/08-core-utils-web branch from 9e9b1dc to ebfd588 Compare August 27, 2026 17:56
@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant