Skip to content

Lint Roller 9: root, core - #23501

Open
kalverra wants to merge 2 commits into
DX-5066/08-core-utils-webfrom
DX-5066/09-core-root
Open

Lint Roller 9: root, core#23501
kalverra wants to merge 2 commits into
DX-5066/08-core-utils-webfrom
DX-5066/09-core-root

Conversation

@kalverra

Copy link
Copy Markdown
Collaborator

Issues Fixed

Linter Issues Fixed
testifylint 102
revive 49
prealloc 31
gocritic 15
staticcheck 12
bodyclose 2
Total 211

Packages Covered

  • . (root)
  • core

Stack created with GitHub Stacks CLIGive Feedback 💬

@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
* 💬 73 @smartcontractkit/foundations, @smartcontractkit/core
/core/capabilities/ 💬 19 @smartcontractkit/keystone, @smartcontractkit/capabilities-team
/core/capabilities/confidentialrelay/ 2 @smartcontractkit/privacy
/core/services/ocr*/ 💬 1 @smartcontractkit/foundations, @smartcontractkit/core
/core/services/llo/ 💬 2 @smartcontractkit/data-streams-engineers, @smartcontractkit/core
/core/services/vrf/ 💬 1 @smartcontractkit/dev-services, @smartcontractkit/core
/tools/plugout/ 💬 1 @smartcontractkit/devex-cicd, @smartcontractkit/core

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Aug 23, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestConnectionManager_ReadyForTrafficRequiresEveryShard The test failed because a node was not ready for traffic, indicating a connectivity or configuration issue with the shards. Logs ↗︎

View Full Report ↗︎Docs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are plugins being bumped?

@kalverra
kalverra force-pushed the DX-5066/09-core-root branch from c602fd0 to 9a7056b Compare August 27, 2026 17:56
@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants