Skip to content

Lint Roller 10: core/scripts (chaincli, vrfv2, vrfv2plus) - #23502

Open
kalverra wants to merge 4 commits into
DX-5066/09-core-rootfrom
DX-5066/10-scripts
Open

Lint Roller 10: core/scripts (chaincli, vrfv2, vrfv2plus)#23502
kalverra wants to merge 4 commits into
DX-5066/09-core-rootfrom
DX-5066/10-scripts

Conversation

@kalverra

Copy link
Copy Markdown
Collaborator

Issues Fixed

Linter Issues Fixed
revive 112
prealloc 84
gocritic 38
staticcheck 26
testifylint 12
Total 272

Packages Covered

  • core/scripts/chaincli/...
  • core/scripts/vrfv2/...
  • core/scripts/vrfv2plus/...
  • core/scripts/...

Stack created with GitHub Stacks CLIGive Feedback 💬

@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Aug 23, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestConnectionManager_ReadyForTrafficRequiresEveryShard The test failed because an unexpected node address error occurred, indicating a problem with node readiness or network connection. Logs ↗︎

View Full Report ↗︎Docs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major change - what is the rationale?

@kalverra
kalverra force-pushed the DX-5066/10-scripts branch from 35dd90f to df00ad1 Compare August 27, 2026 17:56
@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants