Fix Flaky TestDonTimeProvider_GetDONTime_requestTimeout

[kalverra]

Fixes a flake in TestDonTimeProvider_GetDONTime_requestTimeout where an overloaded CI runner would hit issues with timing. To do so, we inject a clockwork.Clock for testing.

• Test in Trunk
• Recent flake

[github-actions]

👋 kalverra, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

[github-actions]

✅ No conflicts with other open PRs targeting develop

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[Copilot]

Pull request overview

Risk Rating: LOW

This PR addresses a flaky workflow engine test (TestDonTimeProvider_GetDONTime_requestTimeout) by making DON time request timeouts deterministic in tests via an injected clockwork.Clock, while preserving existing runtime behavior by defaulting to a real clock.

Changes:

• Injected a clockwork.Clock into DonTimeProvider and used it to create the request timeout timer.
• Updated the flaky timeout test to use a clockwork.FakeClock and drive time deterministically.
• Updated workflow engine call sites to pass the engine’s configured clock into NewDonTimeProvider.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
core/services/workflows/v2/time_provider.go	Adds an injectable clock to DonTimeProvider and uses it for the request timeout timer.
core/services/workflows/v2/time_provider_test.go	Reworks the timeout test to use a fake clock and avoid real-time sleeps/elapsed assertions.
core/services/workflows/v2/engine.go	Passes e.cfg.Clock into NewDonTimeProvider at all call sites.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[trunk-io]

   

View Full Report ↗︎ ⋅ Docs