Repository navigation
fix(sio-client): accept 0 for reconnectionAttempts, reconnectionDelay and reconnectionDelayMax - #5624
Open
mark1russell7 wants to merge 1 commit into
Conversation
… and reconnectionDelayMax The constructor of the Manager and the Backoff used "||", so the value 0 in the options was replaced by the default value (Infinity, 1000 and 5000), while the setters accepted 0. With reconnectionAttempts: 0, the client retried forever, and reconnect_failed was never emitted. Related: socketio/socket.io-client#1231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
The constructor of the Manager reads
reconnectionAttempts,reconnectionDelayandreconnectionDelayMaxwith||, so the value0becomes the default value (Infinity,1000and5000).Backoffdoes the same forminandmax. The setters accept0.New behavior
The constructor and
Backoffuse??, asrandomizationFactoralready does. The value0is kept.factorkeeps||: a factor of0gives no backoff.Two tests are added in
test/connection.ts: the getters andbackoff.duration()return0, and a Manager withreconnectionAttempts: 0emitsreconnect_failedand noreconnect_attempt.The tests ran in GitHub Actions (Node.js 24.22.2 on Linux): the new tests with the
libfolder of upstream main (before), then with this change (after), thennpm testof socket.io-client with this change:The failures before the change:
Other information (e.g. related issues)
Closes #5618
This PR was prepared with AI assistance (Claude). The tests above were run before and after the change, with the results above.
🤖 Generated with Claude Code