Repository navigation
fix(sio-client): set recovered to false when the server does not use connection state recovery - #5625
Open
mark1russell7 wants to merge 1 commit into
Open
mark1russell7 wants to merge 1 commit into
mark1russell7 wants to merge 1 commit into
Conversation
…connection state recovery Without connection state recovery, the CONNECT packet of the server has no "pid" attribute, so socket.recovered was undefined instead of false, although its type is boolean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
onconnect()setsthis.recovered = pid && this._pid === pid. When the server does not use connection state recovery,pidisundefined, sosocket.recoveredbecomesundefined, although its type isboolean.New behavior
this.recovered = !!pid && this._pid === pid, so the value is always a boolean.A test is added in
test/connection-state-recovery.ts("should not be recovered when the server does not use connection state recovery").The tests ran in GitHub Actions (Node.js 24.22.2 on Linux): the new tests with the
libfolder of upstream main (before), then with this change (after), thennpm testof socket.io-client with this change:The failures before the change:
Other information (e.g. related issues)
Closes #5619
This PR was prepared with AI assistance (Claude). The tests above were run before and after the change, with the results above.
🤖 Generated with Claude Code